diff options
| author | Christophe Besson <cbesson@gmail.com> | 2026-09-06 23:42:59 +0200 |
|---|---|---|
| committer | Christophe Besson <cbesson@gmail.com> | 2026-09-06 23:42:59 +0200 |
| commit | 920284009d634cb568f95b3e93b93012c4b803bb (patch) | |
| tree | 5f86205d3e659075b532b043005152ad57e7ca3a /conftest.py | |
| parent | 13ccc4a16c604f46ed10b6c5dbfbc8fdd7d008c0 (diff) | |
| download | meshbay-920284009d634cb568f95b3e93b93012c4b803bb.tar.gz | |
feat(client): bring back New folder, icon-only — and close the hole it opened
The control was hidden and its `canCreateDir` left computed and unused. It is
back in the Files toolbar as an icon: the toolbar already carries one labelled
primary action, and a second beside it competes for the width the breadcrumb
trail needs. The name is in `title` *and* `aria-label` — a title is invisible
to a screen reader on a button with no text, so an icon-only control without
both is simply unnamed for anyone not reading with their eyes.
Its gate changes. It required `isNodeAdmin`, which contradicted the node's own
rule — "making a directory is not a privileged act; a member who can add a file
can organise where it goes" — and hid the control from everyone who could have
used it. It now follows the Upload button: a writable root, and not at the top
of a group, where the level is the set of roots rather than a directory on
anyone's disk.
Restoring it surfaced a real gap. `_do_dir_create` never learned about RO/RW:
`_do_file_upload` gained the `writable` check with the model and this one did
not, so a member refused a file in a published library could still leave empty
directories all through it, and could write to a drive mid-eject. Read-only has
to mean read-only for every way of writing, not just for files.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011pvMdvLBG92jyhvD5pD6us
Diffstat (limited to 'conftest.py')
0 files changed, 0 insertions, 0 deletions