summaryrefslogtreecommitdiffstats
path: root/packages/meshbay-hub/tests/test_security_headers.py
diff options
context:
space:
mode:
authorChristophe Besson <cbesson@gmail.com>2026-09-01 20:03:03 +0200
committerChristophe Besson <cbesson@gmail.com>2026-09-01 20:03:03 +0200
commitf2915bc7b1550b80cadfa36f5910223106cb3bfe (patch)
tree34fa6760db608968057feac31b5f38bcca28bfa4 /packages/meshbay-hub/tests/test_security_headers.py
parent24d29e910c8d1649a1cd51969f27b921b94d97e3 (diff)
downloadmeshbay-f2915bc7b1550b80cadfa36f5910223106cb3bfe.tar.gz
fix(hub): send a CSP and protective headers on every response
The SPA shell and its assets went out with no Content-Security-Policy and no X-Content-Type-Options / Referrer-Policy / X-Frame-Options — so an injection that reached the SPA (rendered third-party OpenGraph data, a federated group name, chat content) had nothing stopping it from loading more code or exfiltrating to any host, and the page could be framed by any site. A middleware in `create_app` now adds all four to every response. `webapp.CSP` is deliberately the *same* policy the desktop client's protocol handler already enforces on these exact UI files, plus the two reCAPTCHA hosts the sign-up widget needs: `default-src 'none'`, `script-src 'self' 'wasm-unsafe-eval' <recaptcha>` (the hub's own origin is not a script source — T3), `style-src 'self' 'unsafe-inline'` (htm/preact inline `style=` only, nothing executes), `connect-src 'self' https: wss:`, `frame-ancestors 'none'`, `base-uri 'none'`, `form-action 'none'`. The shell's dead `<script>window.__MB_ASSET_V = ...</script>` is removed (nothing has ever read it) so `script-src` needs no inline allowance. Needs verification against the running SPA — a mis-tuned CSP shows as a blank page — but it matches a policy already proven with these files under Electron. Second-review L5 / third-review M5. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011pG75yGK3NthNfyjH74omG
Diffstat (limited to 'packages/meshbay-hub/tests/test_security_headers.py')
-rw-r--r--packages/meshbay-hub/tests/test_security_headers.py65
1 files changed, 65 insertions, 0 deletions
diff --git a/packages/meshbay-hub/tests/test_security_headers.py b/packages/meshbay-hub/tests/test_security_headers.py
new file mode 100644
index 0000000..b4d7e6d
--- /dev/null
+++ b/packages/meshbay-hub/tests/test_security_headers.py
@@ -0,0 +1,65 @@
+"""
+The hub sends a Content-Security-Policy and the other protective headers on
+every response — the SPA shell, its assets, and the API alike.
+
+Second-review L5 / third-review M5: previously there were none, so an injection
+that landed in the SPA (rendered third-party OG data, a federated group name,
+chat content) had nothing stopping it from loading more code or exfiltrating.
+"""
+
+import pytest
+from meshbay_hub.api.webapp import CSP
+
+
+def _directive(csp: str, name: str) -> str:
+ for part in csp.split(";"):
+ part = part.strip()
+ if part == name or part.startswith(name + " "):
+ return part
+ return ""
+
+
+@pytest.mark.asyncio
+async def test_the_spa_shell_carries_the_policy(client):
+ r = await client.get("/")
+ assert r.headers["content-security-policy"] == CSP
+ assert r.headers["x-content-type-options"] == "nosniff"
+ assert r.headers["x-frame-options"] == "DENY"
+ assert "referrer-policy" in r.headers
+
+
+@pytest.mark.asyncio
+async def test_the_api_carries_the_headers_too(client):
+ r = await client.get("/v1/health")
+ assert r.status_code == 200
+ assert "content-security-policy" in r.headers
+ assert r.headers["x-content-type-options"] == "nosniff"
+
+
+@pytest.mark.asyncio
+async def test_even_a_404_carries_the_headers(client):
+ # The middleware runs on every response, so a probe for a missing path
+ # cannot be framed or content-sniffed either.
+ r = await client.get("/no/such/path")
+ assert r.status_code == 404
+ assert r.headers["x-frame-options"] == "DENY"
+
+
+def test_the_policy_is_locked_down_where_it_matters():
+ assert "default-src 'none'" in CSP # covers object-src, etc.
+ assert _directive(CSP, "frame-ancestors") == "frame-ancestors 'none'"
+ assert _directive(CSP, "base-uri") == "base-uri 'none'"
+
+ script = _directive(CSP, "script-src")
+ # The hub's own origin must not be able to serve executable script (T3):
+ # 'self' and the wasm token are fine, a bare `https:` scheme is not.
+ assert "'self'" in script and "'wasm-unsafe-eval'" in script
+ assert "https:" not in script.split()
+
+
+def test_recaptcha_is_the_only_external_origin():
+ hosts = {"https://www.google.com", "https://www.gstatic.com"}
+ for part in CSP.split(";"):
+ for tok in part.strip().split()[1:]:
+ if tok.startswith(("http://", "https://")):
+ assert tok in hosts, f"unexpected external origin in CSP: {tok}"