diff options
| author | Christophe Besson <cbesson@gmail.com> | 2026-09-07 02:04:42 +0200 |
|---|---|---|
| committer | Christophe Besson <cbesson@gmail.com> | 2026-09-07 02:04:42 +0200 |
| commit | fbcb3461c5bfc0f9b902287896d655da6f0bfcd0 (patch) | |
| tree | 18678f7fbd415d6b29d7c4351861364b7a38c7c4 /packages/meshbay-hub/tests | |
| parent | 375419c041a4523614b3a1b98fa54fb5acb1b8bf (diff) | |
| download | meshbay-fbcb3461c5bfc0f9b902287896d655da6f0bfcd0.tar.gz | |
fix(client): drop the "No changes to save" hint beside Save
The hint was added alongside the .app-save control, when an inert Save
was indistinguishable from an enabled one and the reader had no way to
tell "nothing changed" from "this is broken". The control now reads as
disabled on its own, so the sentence beside it is noise.
Removing it also removes what only existed to carry it: the .app-save-row
wrapper, its two style rules, and settings_app.no_changes in all ten
locales.
test_the_disabled_state_is_visually_distinct sliced the stylesheet on
.app-save-row; it now stops at the closing brace of .app-save:disabled.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011pvMdvLBG92jyhvD5pD6us
Diffstat (limited to 'packages/meshbay-hub/tests')
| -rw-r--r-- | packages/meshbay-hub/tests/test_app_settings_plugin.py | 13 |
1 files changed, 1 insertions, 12 deletions
diff --git a/packages/meshbay-hub/tests/test_app_settings_plugin.py b/packages/meshbay-hub/tests/test_app_settings_plugin.py index 8a095af..b8afc23 100644 --- a/packages/meshbay-hub/tests/test_app_settings_plugin.py +++ b/packages/meshbay-hub/tests/test_app_settings_plugin.py @@ -347,21 +347,10 @@ def test_save_is_a_button_and_not_dim_text(pane): f"{pane}'s Save is still styled as dim text") -@pytest.mark.parametrize("pane", sorted(PANE_FLAGS)) -def test_an_inert_save_says_why(pane): - """ - A disabled control that explains itself is the difference between "nothing - changed" and "this is broken". Without it the reader has to know what the - pane counts as a change. - """ - source = (STATIC / pane).read_text(encoding="utf-8") - assert "app-save-why" in source and "settings_app.no_changes" in source - - def test_the_disabled_state_is_visually_distinct(): css = (STATIC / "style.css").read_text(encoding="utf-8") rule = css[css.index(".app-save {"):] - rule = rule[:rule.index(".app-save-row")] + rule = rule[:rule.index("}", rule.index(".app-save:disabled")) + 1] assert "var(--accent)" in rule, "an enabled Save has no fill" disabled = rule[rule.index(".app-save:disabled"):] assert "background: none" in disabled and "--text-dim" in disabled, ( |