feat(node): the operator can close uploading to everyone but themselves

A group where every member may add files stays the default. Some groups want a
library the operator curates, and until now the only way to get one was to
designate no upload root at all — which refuses the operator too.

**The node enforces it; the interface merely stops offering it.** The Upload
button in the Files toolbar and the paperclip in the chat composer both
disappear, which is a courtesy to the people who are not trying. The control is
`_do_file_upload` refusing with `member_upload_off`, so a member on an old tab,
or one speaking MNP directly, gets the same answer. There is a test for each,
and the enforcement test is in the node package rather than beside the UI one so
nobody reads the hidden button as the mechanism.

**Changing it is a signed operator instruction** — `OP_MEMBER_UPLOAD`, on the
same path as removing a member. An unsigned one would let any member turn it
back on and make the setting a suggestion. The transcript's subject is `on` or
`off`: what the operator is shown before signing has to name the outcome, not
the operation.

**It lives on the node**, in a new `group_settings` table in `roster.db`. Not
the hub, which has no business deciding who may write to someone else's disk.
Not `node.toml` either: that file is hand-written and full of comments recording
decisions, `ops.py` appends to it rather than round-tripping it through a
writer, and a setting toggled from a panel must not rewrite the operator's file
or need a restart. The value is cached in the group context because the upload
path is synchronous, and the signed operation updates both — storing it without
applying it would make the panel say one thing while the node did another.

**Absent means allowed**, at every layer: no row in the table, no key in the
context, no field in `handshake_ack`. An older node and an older client both
behave exactly as before, and upgrading never silently closes a group. Each of
those three has its own test, because they fail independently.

The operator is always exempt — otherwise turning it off locks them out of their
own node with a config file and a restart as the only way back. `is_node_admin`
was being computed in two places by then and is now one function, since two
copies of "is this the operator" is how the ack and the gate come to disagree.

A change reaches everyone already connected via `member_upload_ack`, so the
button goes without a reconnection. That message is both a broadcast and the
reply to the request that caused it, which is why the client does not return
early on it.

Docs updated for a cold start: draft-v6 §2.1b and change 9, a new "Where Phase
13 stands" section in CLAUDE.md recording what is built, deployed and still
missing, the module map row, and desktop-client-v1 §10b on the Settings tab and
where group settings live.

883 tests pass.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1 files changed, 87 insertions, 1 deletions

diff --git a/packages/meshbay-node/src/meshbay_node/transport/webrtc_server.py b/packages/meshbay-node/src/meshbay_node/transport/webrtc_server.py
index 9d16f82..22e5e15 100644
--- a/packages/meshbay-node/src/meshbay_node/transport/webrtc_server.py
+++ b/packages/meshbay-node/src/meshbay_node/transport/webrtc_server.py
@@ -62,6 +62,7 @@ from meshbay_common.adminop import (
     OP_MEMBER_REVOKE,
     OP_GEK_ROTATE,
     OP_MEMBER_UNPIN,
+    OP_MEMBER_UPLOAD,
     admin_transcript,
 )
 from meshbay_common.crypto import pk_to_b64, wrap_gek_aes
@@ -469,6 +470,8 @@ class WebRTCPeerSession:
                 self._spawn(self._do_device_list(msg))
             elif mtype == MNP.DEVICE_REVOKE:
                 self._spawn(self._do_device_revoke(msg))
+            elif mtype == MNP.MEMBER_UPLOAD:
+                self._do_member_upload(msg)
             elif mtype == MNP.MEMBER_UNPIN:
                 self._do_member_unpin(msg)
             elif mtype == MNP.GEK_ROTATE:
@@ -687,7 +690,11 @@ class WebRTCPeerSession:
             "proof": base64.b64encode(node_proof).decode(),
             "sig": base64.b64encode(
                 self._ctx["sk_node"].sign(node_transcript)).decode(),
-            "is_node_admin": bool(node_user_id and self._user_id == node_user_id),
+            "is_node_admin": self._is_node_admin(),
+            # So the interface knows whether to offer uploading at all. Not a
+            # permission — the node refuses regardless — but without it the
+            # only way to discover the answer is to try.
+            "member_upload": bool(self._group_ctx().get("member_upload", True)),
         }
         if node_user_id:
             ack["node_user_id"] = node_user_id
@@ -1568,6 +1575,58 @@ class WebRTCPeerSession:
         self._send({"type": MNP.MEMBER_UNPIN_ACK, "v": MNP_VERSION,
                     "user_id": user_id})
 
+    def _do_member_upload(self, msg: dict) -> None:
+        """
+        Turn uploading by ordinary members on or off, for this group.
+
+        Signed like every other operator action. The setting decides who may
+        write to the operator's disk, so a node that took it from an unsigned
+        message would let any member turn it back on for everyone — the control
+        would be a suggestion.
+        """
+        if "allowed" not in msg:
+            self._send({"type": "error", "detail": "Missing allowed"})
+            return
+        if not self._has_admin_authority():
+            self._send({"type": "error", "detail": "No authorized key for this"})
+            return
+        # The subject is what the operator is shown before signing, so it has to
+        # name the outcome rather than the operation.
+        self._issue_admin_challenge(
+            OP_MEMBER_UPLOAD, "on" if msg.get("allowed") else "off")
+
+    async def _admin_exec_member_upload(
+        self, pending: dict, transcript: bytes, sig: bytes,
+    ) -> None:
+        allowed = pending["subject"] == "on"
+        if not await self._verify_admin_sig(transcript, sig):
+            self._send({"type": "error", "detail": "Signature verification failed"})
+            self._audit("admin_auth_failed", f"member_upload:{pending['subject']}")
+            return
+        roster = self._ctx.get("roster")
+        if roster is None:
+            self._send({"type": "error", "detail": "No roster on this node"})
+            return
+        await roster.set_member_upload(self._group_id or "", allowed,
+                                       set_by=self._user_id)
+        # Stored *and* applied. The upload path is synchronous and reads this
+        # dict; leaving it to the next restart would make the panel say one
+        # thing while the node did another.
+        self._group_ctx()["member_upload"] = allowed
+        self._audit("member_upload", pending["subject"])
+
+        # Everyone already connected is told, rather than finding out by having
+        # an upload refused. Enforcement does not depend on this reaching them —
+        # it is the node that refuses — but a button that stays visible until
+        # the next reconnection is a button people press.
+        notice = {"type": MNP.MEMBER_UPLOAD_ACK, "v": MNP_VERSION,
+                  "allowed": allowed}
+        for uid, session in list(self._peer_registry().items()):
+            try:
+                session._send(notice)
+            except Exception:
+                pass
+
     async def _run_op(self, fn, *args, **kwargs):
         """
         Call an operation from `meshbay_node.ops` with the daemon's own view.
@@ -1995,6 +2054,19 @@ class WebRTCPeerSession:
                         "filename": filename})
             return
 
+        # The operator can close uploading to everyone but themselves. Enforced
+        # here rather than by hiding a button: the button is a courtesy to the
+        # people who are not trying, and this is the part that holds against
+        # someone who is. `is_node_admin` is computed from the identity this
+        # node pinned, never from a hub claim.
+        if not ctx.get("member_upload", True) and not self._is_node_admin():
+            self._send({"type": "error",
+                        "detail": "Uploading is turned off for this group",
+                        "code": "member_upload_off",
+                        "filename": filename})
+            self._audit("upload_refused", filename[:64])
+            return
+
         roots: RootSet | None = ctx.get("roots")
         upload_root = roots.upload_root if roots else None
         if upload_root is None:
@@ -2189,6 +2261,17 @@ class WebRTCPeerSession:
         if ident:
             self._pinned_pk = ident["pk_ed25519"]
 
+    def _is_node_admin(self) -> bool:
+        """
+        Whether the peer on this connection is the node's operator.
+
+        Was written out twice — once in the handshake ack and once at the gate
+        below it — which is how the two come to disagree. From the node's own
+        record of who it belongs to, never from a hub claim.
+        """
+        node_user_id = self._ctx.get("node_user_id")
+        return bool(node_user_id and self._user_id == node_user_id)
+
     def _has_admin_authority(self) -> bool:
         """
         Cheap synchronous pre-check: is there anyone who could authorize this?
@@ -2269,6 +2352,9 @@ class WebRTCPeerSession:
         elif pending["op"] == OP_MEMBER_UNPIN:
             self._spawn(
                 self._admin_exec_member_unpin(pending, transcript, sig_bytes))
+        elif pending["op"] == OP_MEMBER_UPLOAD:
+            self._spawn(
+                self._admin_exec_member_upload(pending, transcript, sig_bytes))
         else:
             self._send({"type": "error", "detail": "Unknown admin operation"})