diff options
| author | Christophe Besson <cbesson@gmail.com> | 2026-08-24 19:46:06 +0200 |
|---|---|---|
| committer | Christophe Besson <cbesson@gmail.com> | 2026-08-24 19:46:06 +0200 |
| commit | 62253b9592a83ce152d0c64471e20514218fb132 (patch) | |
| tree | d41b84661da3252045937f5a90dc45ca7b029edc /packages/meshbay-node/src | |
| parent | d053d083627f1f9f010752f8ad67941e22d49f27 (diff) | |
| download | meshbay-62253b9592a83ce152d0c64471e20514218fb132.tar.gz | |
feat(hub): consolidate loose tracks, "&"/"and" fold, player close/queue
Album-grid readability, part two:
- groupMusicEntries (music-app.js): an album bucket left with exactly
one track - a real album tag, but only one song from it, not the
whole release - clutters the grid the same way an untagged loose
track does. Both kinds now fold into one "<artist> - Various" tile
per artist, unless there is only one leftover track overall, where
relabeling buys nothing and the track keeps its own name (or the
generic placeholder, if it never had one).
- foldKey also normalizes "&" vs "and" ("Artist & The Band" / "Artist
and The Band" is one act, tagged both ways across different rips of
the same catalogue) alongside the existing case/whitespace fold.
- music-player.js: a close button pauses and tears the player down;
an unmount cleanup effect (pause, revoke every cached blob URL)
fires either way, whether that's the close button or the shell
tearing the bar down on its own. A "current queue" button opens an
overlay listing the whole playing queue with the current track
highlighted, click any to jump to it - works identically regardless
of how the queue was built (an album, the consolidated misc bucket,
a single standalone track), since it only ever reads the player's
own live tracks/order/pos.
- group-page.js: this component is not remounted when switching to a
*different* group on the same /group/:id route (only the groupId
prop changes) - so without an explicit reset, music from one group
would carry into the next one opened. Resets musicQueue to null on
groupId change; a tab switch inside one group still leaves it alone.
- Scrubbed real artist/band names that had leaked into code comments
and test fixtures (enrich_audio.py's docstrings, several
test_enrich_audio.py assertions, a music-app.js comment) - replaced
with generic placeholders, no behavioural change.
- i18n: music.various, music.player_close, music.player_queue,
music.queue_title added across all ten locales.
Client-side only except none of this touches the node at all. npm run
sync-ui re-run. Full suite: 1129 passed, no regressions.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KBi7ALLGfwcjBXt57yNMcy
Diffstat (limited to 'packages/meshbay-node/src')
| -rw-r--r-- | packages/meshbay-node/src/meshbay_node/indexer/enrich_audio.py | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/packages/meshbay-node/src/meshbay_node/indexer/enrich_audio.py b/packages/meshbay-node/src/meshbay_node/indexer/enrich_audio.py index 9ecf1b9..5225d4f 100644 --- a/packages/meshbay-node/src/meshbay_node/indexer/enrich_audio.py +++ b/packages/meshbay-node/src/meshbay_node/indexer/enrich_audio.py @@ -198,8 +198,8 @@ def _read_tags_and_cover(path: Path) -> tuple[dict, float | None, bytes | None]: # A folder name used as a last-resort artist/album, cleaned of the # punctuation-as-separator and release-tag noise this era of rip is full of -# ("L_Oeuf_Raide_-_Berlin_Eggsile", "Sinsemilia - Premiere Recolte [MP3 -# 320kbps Album]"). Same spirit as title_parse.naive_title for video, kept +# (underscores standing in for spaces, a bitrate/quality tag still attached +# to the name). Same spirit as title_parse.naive_title for video, kept # separate because the junk vocabulary differs (bitrates and rip tags, not # edition/language tags). # A whole bracketed/parenthesized group is dropped if it contains any rip-tag @@ -228,12 +228,11 @@ def _split_top_level_folder(name: str) -> tuple[str, str | None]: directly under the group's root (§ below) — there is no further ancestor to call "artist" without leaving the root entirely. The common convention for a single-release folder at that level is - "Artist - Album ...junk..." ("GHOST DOG - Soundtrack", - "cypress_hill_-los_grandes__xitos_en_espa_ol"); split on the first - " - " when the cleaned name has one. Otherwise the whole (cleaned) name - becomes the artist alone, which is the *more* common real shape here — - a flat per-artist folder with no album subfolder at all ("Ben Harper", - "bob_marley", "Renaud"). + "Artist - Album ...junk..." (e.g. a soundtrack folder named after the + film, or a release folder with the ripper's tags still attached); split + on the first " - " when the cleaned name has one. Otherwise the whole + (cleaned) name becomes the artist alone, which is the *more* common real + shape here — a flat per-artist folder with no album subfolder at all. """ cleaned = _clean_folder_name(name) m = re.match(r"^(.{2,60}?)\s*-\s*(.{2,80})$", cleaned) |