diff options
| author | Christophe Besson <cbesson@gmail.com> | 2026-08-29 14:58:30 +0200 |
|---|---|---|
| committer | Christophe Besson <cbesson@gmail.com> | 2026-08-29 14:58:58 +0200 |
| commit | 71b7a310ce938f072fe20f27eeeadd40685f1ad1 (patch) | |
| tree | 75a7d93d58fda0e742dd9b1c94538b532c34464a /packages/meshbay-node/tests/test_tmdb_override_policy.py | |
| parent | b7733e812fadd6007976d262bd1d793572a36ba7 (diff) | |
| download | meshbay-71b7a310ce938f072fe20f27eeeadd40685f1ad1.tar.gz | |
fix(node): correct TMDB movie matching, per-file overrides, rematch
A batch of wrong poster-grid matches found live on a real library
(2026-08-29): a two-volume film's second part matched the first; a
numbered sequel matched a same-year making-of documentary; several
entries of one franchise matched a single early entry whose localized
TMDB title is the franchise name; one matched nothing. One mechanism:
_tmdb_search returned the first candidate query whose title-similarity
ratio merely cleared 0.6, before alternative_title / the Roman-numeral
variant was ever tried.
Matching:
- title_parse: fold guessit's volume/part number back into display_title
so the parts of a multi-part film stay distinct in the query, the card
and the override.
- _tmdb_search: keep a strong PASS 1 fast path (ratio >= 0.85, one
request), otherwise score every candidate query and pick the best. A
year-exact rescue lifts a sub-0.6 top hit to the confidence floor only
when TMDB's own year-filtered result lands exactly on the filename's
year. No local re-ranking of any single result list; no tmdb.py change.
Fix match / rematch:
- _admin_exec_tmdb_override: a movie override touches its own file only
(guessit gives a whole franchise one display_title); a show override
still fans out. Corrected files are marked in media_cache.tmdb_override.
- media_cache: tmdb_override table; clear_file_tmdb / clear_tmdb_matches
drop auto-resolved matches while sparing manual corrections.
- ops.rematch_video + `meshbay-node video rematch` (loopback endpoint +
CLI verb): re-resolve a group's video matches after a matcher fix.
file_tmdb is keyed by content hash and otherwise only pruned on
deletion, so nothing dislodged a cached match before.
- a rename now drops the stale auto match too (daemon
_reenrich_renamed_video_entries).
UI:
- VideoDetailModal shows the source filename and resolved TMDB id; an
unmatched poster gets a badge (3 new video.* i18n keys x 10 locales).
So a wrong match can actually be identified before hitting Fix match.
docs/mediacenter.md 10.1 records this and the V8-V13 follow-up backlog
(show-branch ladder, year-aware _best_match, wider sequel_variants, the
0.6-0.85 extra calls, movie grid merge, per-card rematch).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018BMLQjqFGCize2KtNBT79v
Diffstat (limited to 'packages/meshbay-node/tests/test_tmdb_override_policy.py')
| -rw-r--r-- | packages/meshbay-node/tests/test_tmdb_override_policy.py | 68 |
1 files changed, 68 insertions, 0 deletions
diff --git a/packages/meshbay-node/tests/test_tmdb_override_policy.py b/packages/meshbay-node/tests/test_tmdb_override_policy.py index c2f28e6..0717a0c 100644 --- a/packages/meshbay-node/tests/test_tmdb_override_policy.py +++ b/packages/meshbay-node/tests/test_tmdb_override_policy.py @@ -195,6 +195,74 @@ async def test_override_updates_every_entry_sharing_the_display_title(tmp_path): await media_cache.close() +async def test_movie_override_touches_only_the_one_file(tmp_path): + """ + guessit gives a whole franchise the same display_title (every + "<franchise>.-.<year>.-.<subtitle>.mkv" parses to the franchise name), + so fanning a *movie* override out by display_title corrected the wrong + films (found live, 2026-08-29). A movie override applies to its own + file_id only; a show override still fans out (test above). + """ + session = _session(tmp_path, "op", operator="op") + index = session._ctx["index"] + m1 = IndexEntry(id="b" * 64, name="Some.Agent.42.-.2008.-.Second.Errand.mkv", + path="movies", size=1, type="video", added_at=0, + display_title="Some Agent 42") + m2 = IndexEntry(id="c" * 64, name="Some.Agent.42.-.2012.-.Third.Errand.mkv", + path="movies", size=1, type="video", added_at=0, + display_title="Some Agent 42") + index.add_entry(m1) + index.add_entry(m2) + + media_cache = MediaCache(db_path=tmp_path / "media_cache.db") + await media_cache.open() + try: + session._ctx["media_cache"] = media_cache + session._ctx["tmdb_client"] = None + session._verify_admin_sig = lambda transcript, sig: _true() + session._peer_registry = lambda: {} + + await session._admin_exec_tmdb_override( + {"subject": f"file_id={m1.id},tmdb_id=302,media_type=movie"}, + b"transcript", b"sig") + + assert await media_cache.get_file_tmdb(m1.id) == ("302", "movie") + assert await media_cache.get_file_tmdb(m2.id) is None, ( + "a movie override must not fan out to another film sharing the " + "parsed franchise display_title") + # the corrected file is also shielded from a later ops.rematch_video + assert await media_cache.clear_tmdb_matches([m1.id, m2.id]) == 0 + finally: + await media_cache.close() + + +async def test_show_override_fans_out_and_marks_every_corrected_file(tmp_path): + session = _session(tmp_path, "op", operator="op") + index = session._ctx["index"] + s1 = _entry("shared/S1", "s01e01.mkv", "Some Show") + s2 = _entry("shared/S2", "s02e01.mkv", "Some Show") + index.add_entry(s1) + index.add_entry(s2) + + media_cache = MediaCache(db_path=tmp_path / "media_cache.db") + await media_cache.open() + try: + session._ctx["media_cache"] = media_cache + session._ctx["tmdb_client"] = None + session._verify_admin_sig = lambda transcript, sig: _true() + session._peer_registry = lambda: {} + + await session._admin_exec_tmdb_override( + {"subject": f"file_id={s1.id},tmdb_id=2255,media_type=tv"}, + b"transcript", b"sig") + + assert await media_cache.get_file_tmdb(s2.id) == ("2255", "tv") # fan-out + # both episodes are marked, so ops.rematch_video spares the correction + assert await media_cache.clear_tmdb_matches([s1.id, s2.id]) == 0 + finally: + await media_cache.close() + + class _FakeTmdbClient: """Just enough for _tmdb_build_meta to run end to end — a fixed, deterministic response, not a search stub (the override already has a |