diff options
| author | Christophe Besson <cbesson@gmail.com> | 2026-09-09 09:01:51 +0200 |
|---|---|---|
| committer | Christophe Besson <cbesson@gmail.com> | 2026-09-09 09:01:51 +0200 |
| commit | 7000082b748bf608484f94d30d63b2c6b83e6814 (patch) | |
| tree | 06b0538b828465a910a5aa3e2d98f7584ac4b20d /packages/meshbay-node | |
| parent | 88de521725d8de10eb8bf956b31cf9ce70a81f33 (diff) | |
| download | meshbay-7000082b748bf608484f94d30d63b2c6b83e6814.tar.gz | |
log(node): a transfer open is INFO, not DEBUG
"The node saw no transfer" was concluded twice from a journal that could not
have shown one: the open was logged at DEBUG, and the daemon runs at INFO. Two
diagnoses were built on that non-observation, and both were wrong.
Turning the root logger up to DEBUG is not the answer either — aiortc logs every
SCTP chunk, which on a 2 GB download is both unreadable and slow. One line per
transfer is not a volume problem, and it is the line that answers "did the
client ever ask for a slot, and what was it told".
Node suite 1172 passed.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HCGdheDLxGReuKHga3BtST
Diffstat (limited to 'packages/meshbay-node')
| -rw-r--r-- | packages/meshbay-node/src/meshbay_node/transport/webrtc_server.py | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/packages/meshbay-node/src/meshbay_node/transport/webrtc_server.py b/packages/meshbay-node/src/meshbay_node/transport/webrtc_server.py index 6a75b52..ce599cc 100644 --- a/packages/meshbay-node/src/meshbay_node/transport/webrtc_server.py +++ b/packages/meshbay-node/src/meshbay_node/transport/webrtc_server.py @@ -3501,8 +3501,14 @@ class WebRTCPeerSession: self._send({"type": "error", "detail": err, "code": err, "tr": tr}) return self._send(self._transfer_state_msg(lease, lease.state)) - log.debug("transfer: open %s %s -> %s (%s)", - kind, tr[:8], lease.state, slots.summary()) + # INFO, not DEBUG. This is the line that answers "did the client ever + # ask for a slot, and what was it told" when somebody reports a stuck + # transfer — and a whole afternoon was spent concluding "the node saw + # nothing" from a journal that could not have shown it. One line per + # transfer is not a volume problem; turning the root logger up to DEBUG + # to see it is, because aiortc logs every SCTP chunk. + log.info("transfer: open %s %s -> %s (%s)", + kind, tr[:8], lease.state, slots.summary()) self._ensure_transfer_sweeper() def _do_transfer_close(self, msg: dict) -> None: |