diff options
Diffstat (limited to 'packages/meshbay-node/tests/test_packaging_win.py')
| -rw-r--r-- | packages/meshbay-node/tests/test_packaging_win.py | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/packages/meshbay-node/tests/test_packaging_win.py b/packages/meshbay-node/tests/test_packaging_win.py index 21aaf29..0cf6367 100644 --- a/packages/meshbay-node/tests/test_packaging_win.py +++ b/packages/meshbay-node/tests/test_packaging_win.py @@ -71,6 +71,25 @@ def test_the_node_runtime_is_carried_as_an_extraresource(): "extraResources puts it") +def test_find_node_binary_strips_stray_cr_from_multiline_where_output(): + """ + where.exe/which can list more than one match on PATH, and each line + keeps its own trailing \\r on Windows. `stdout.trim().split('\\n')[0]` + only strips the ends of the *whole* string, so with 2+ matches a stray + \\r stayed glued to the end of the first line -- which then landed + inside the quoted path written into the Startup .vbs and broke + VBScript's parser with "Unterminated string constant" the next time + Windows ran it at sign-in. Reproduced live 2026-09-05 (this user's own + machine has both a dev venv and an installed build on PATH) and fixed + by splitting on \\r?\\n and trimming each candidate line individually. + """ + main_js = (CLIENT / "src" / "main.js").read_text(encoding="utf-8") + assert "stdout.split(/\\r?\\n/)" in main_js, ( + "findNodeBinary must split where.exe/which output on \\r?\\n and " + "trim each line, not a single stdout.trim() over the whole blob") + assert "stdout.trim().split('\\n')[0]" not in main_js + + def test_firewall_helper_is_carried_as_an_extraresource(): """packaging/win/firewall.ps1 must ride into resources/, at the fixed path installer.nsh invokes it from ($INSTDIR\\resources\\firewall.ps1).""" |