diff options
Diffstat (limited to 'packages/meshbay-node')
| -rw-r--r-- | packages/meshbay-node/tests/test_packaging_win.py | 39 |
1 files changed, 18 insertions, 21 deletions
diff --git a/packages/meshbay-node/tests/test_packaging_win.py b/packages/meshbay-node/tests/test_packaging_win.py index 877994d..7b44bbe 100644 --- a/packages/meshbay-node/tests/test_packaging_win.py +++ b/packages/meshbay-node/tests/test_packaging_win.py @@ -24,16 +24,14 @@ NSH = CLIENT / "build" / "installer.nsh" MAIN_JS = CLIENT / "src" / "main.js" PRELOAD_JS = CLIENT / "src" / "preload.js" -# The "Light" target: Electron client + UI, no bundled node. See -# C:\Users\admin\devel\light-client.md for the evaluation this implements. +# The "Light" target: Electron client + UI, no bundled node. LIGHT_NSH = CLIENT / "build" / "installer-light.nsh" LIGHT_YML = WIN / "electron-builder.light.yml" BUILD_WIN_LIGHT = WIN / "build-win-light.ps1" BUILD_WIN_COMMON = WIN / "build-win-common.ps1" # The "MSIX" target: same feature set as Full, packaged for Microsoft Store -# submission instead of NSIS. See C:\Users\admin\devel\msix-installer.md for -# the plan this implements. +# submission instead of NSIS. MSIX_YML = WIN / "electron-builder.msix.yml" BUILD_WIN_MSIX = WIN / "build-win-msix.ps1" MSIX_EXTENSIONS_XML = CLIENT / "build" / "appx-extensions.xml" @@ -683,8 +681,7 @@ def test_ffmpeg_bundling_is_the_default_not_opt_in(): # ------------------------------------------------------------------------ -# The "Light" target: Electron client + UI, no bundled node. See -# C:\Users\admin\devel\light-client.md for the evaluation. Weak, text- +# The "Light" target: Electron client + UI, no bundled node. Weak, text- # reading evidence throughout, same reasoning as the rest of this file: # there is no electron-builder/PowerShell/NSIS runner here, and it is the # right kind of evidence for what these guard against -- a config drifting @@ -921,9 +918,9 @@ def test_create_group_page_falls_back_when_no_node_is_bundled(): # ------------------------------------------------------------------------ # The "MSIX" target: same feature set as Full, packaged for Microsoft Store -# submission instead of NSIS. See C:\Users\admin\devel\msix-installer.md for -# the plan. Unlike Light, this target keeps the node runtime and both -# service scripts -- what changes is packaging format, not what ships. +# submission instead of NSIS. Unlike Light, this target keeps the node +# runtime and both service scripts -- what changes is packaging format, not +# what ships. # Weak, text-reading evidence throughout, same reasoning as the rest of # this file: there is no electron-builder/appx runner here either. # ------------------------------------------------------------------------ @@ -931,9 +928,9 @@ def test_create_group_page_falls_back_when_no_node_is_bundled(): def test_msix_config_is_standalone_and_keeps_the_full_bundle(): """ Unlike Light, MSIX ships the same node-runtime/ffmpeg/service scripts as - Full -- an AppX install never elevating (msix-installer.md 4) is not a - reason to drop the daemon, only to change how its two elevated - operations get triggered (see the two tests below). --config still + Full -- an AppX install never elevating is not a reason to drop the + daemon, only to change how its two elevated operations get triggered + (see the two tests below). --config still means this file is read alone (app-builder-lib's getConfig), so it cannot silently inherit Full's package.json build.nsis or any signing config meant for NSIS. @@ -979,11 +976,11 @@ def test_msix_declares_no_csc_on_purpose(): No certificateFile/certificateSubjectName/certificateSha1 anywhere in this config -- per app-builder-lib's own windowsSignToolManager.js, an AppX target built with no certificate configured is logged as "Windows - Store only build" and left unsigned; Microsoft signs it at publish time - (msix-installer.md 3). Configuring a cert here would be wasted work, not - extra safety, and would risk this target picking up whatever might one - day be configured for Full's NSIS signing if it were ever added to this - file instead of package.json's own build.win. + Store only build" and left unsigned; Microsoft signs it at publish + time. Configuring a cert here would be wasted work, not extra safety, + and would risk this target picking up whatever might one day be + configured for Full's NSIS signing if it were ever added to this file + instead of package.json's own build.win. """ yml = MSIX_YML.read_text(encoding="utf-8") for forbidden in ("certificateFile", "certificateSubjectName", "certificateSha1"): @@ -993,10 +990,10 @@ def test_msix_declares_no_csc_on_purpose(): def test_msix_declares_the_network_capabilities_firewall_ps1_would_add(): """ Matches firewall.ps1's own rules, which are `-Profile Any` (private AND - public network) -- msix-installer.md 8's #1 open item: whether Windows - actually auto-exempts a full-trust packaged app on the strength of - these declarations is unverified until sideloaded, but the declaration - itself must at least match what the elevated NSIS path grants today, or + public network). Whether Windows actually auto-exempts a full-trust + packaged app on the strength of these declarations is unverified until + sideloaded, but the declaration itself must at least match what the + elevated NSIS path grants today, or an MSIX install would be silently narrower than Full/Light. """ yml = MSIX_YML.read_text(encoding="utf-8") |