From b86981f7b4ffe758136a527542ce256315823a46 Mon Sep 17 00:00:00 2001 From: Christophe Besson Date: Tue, 18 Aug 2026 18:21:57 +0200 Subject: feat(node): the operator can close uploading to everyone but themselves MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A group where every member may add files stays the default. Some groups want a library the operator curates, and until now the only way to get one was to designate no upload root at all — which refuses the operator too. **The node enforces it; the interface merely stops offering it.** The Upload button in the Files toolbar and the paperclip in the chat composer both disappear, which is a courtesy to the people who are not trying. The control is `_do_file_upload` refusing with `member_upload_off`, so a member on an old tab, or one speaking MNP directly, gets the same answer. There is a test for each, and the enforcement test is in the node package rather than beside the UI one so nobody reads the hidden button as the mechanism. **Changing it is a signed operator instruction** — `OP_MEMBER_UPLOAD`, on the same path as removing a member. An unsigned one would let any member turn it back on and make the setting a suggestion. The transcript's subject is `on` or `off`: what the operator is shown before signing has to name the outcome, not the operation. **It lives on the node**, in a new `group_settings` table in `roster.db`. Not the hub, which has no business deciding who may write to someone else's disk. Not `node.toml` either: that file is hand-written and full of comments recording decisions, `ops.py` appends to it rather than round-tripping it through a writer, and a setting toggled from a panel must not rewrite the operator's file or need a restart. The value is cached in the group context because the upload path is synchronous, and the signed operation updates both — storing it without applying it would make the panel say one thing while the node did another. **Absent means allowed**, at every layer: no row in the table, no key in the context, no field in `handshake_ack`. An older node and an older client both behave exactly as before, and upgrading never silently closes a group. Each of those three has its own test, because they fail independently. The operator is always exempt — otherwise turning it off locks them out of their own node with a config file and a restart as the only way back. `is_node_admin` was being computed in two places by then and is now one function, since two copies of "is this the operator" is how the ack and the gate come to disagree. A change reaches everyone already connected via `member_upload_ack`, so the button goes without a reconnection. That message is both a broadcast and the reply to the request that caused it, which is why the client does not return early on it. Docs updated for a cold start: draft-v6 §2.1b and change 9, a new "Where Phase 13 stands" section in CLAUDE.md recording what is built, deployed and still missing, the module map row, and desktop-client-v1 §10b on the Settings tab and where group settings live. 883 tests pass. Co-Authored-By: Claude Opus 5 --- CLAUDE.md | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) (limited to 'CLAUDE.md') diff --git a/CLAUDE.md b/CLAUDE.md index a5469a1..9f63595 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -246,6 +246,28 @@ keypair bundle, or anything that looks like a user's public key. the group named in the invitation (an operator pairs node-wide while opening a group) +## Where Phase 13 stands (2026-08-19) + +Stages A–D are **built and running**, not designed. `docs/desktop-client-v1.md` is still +the decision record; the sections below it describe what was decided, and this says what +exists. + +- Built: named roots, `ops.py` + CLI, device linking and hub device auth, the Electron + client (protocol handler, CSP header, `safeStorage` keys, streamed downloads to disk, + native folder picker), the group Settings tab, per-account resume positions, uploads + the operator can close +- Deployed: the hub runs MNP 0.3 with migration `e5a2b7d31f88`. **The SPA served in + production is older than this tree** — check `/a//` against + `meshbay_hub.api.webapp.ASSET_V` before concluding a fix is missing. `site/` and the + Caddy config have never been deployed +- Not built: D5 (node management panel), D6 (first-run wizard), D8 (`.deb`/`.rpm` — the + package must ship `chrome-sandbox` root-owned 4755), D9 (Python sidecar `group://`), + D10 (video thumbnails), D11 (Windows), D12 (release key and repo) +- One UI source: `packages/meshbay-hub/src/meshbay_hub/static/` is the interface, for the + web and the app alike. `packages/meshbay-client/build/sync-ui.js` copies it and CI + fails if the copy drifts — **never edit `packages/meshbay-client/ui/` by hand** +- Throwaway `e2e*` accounts accumulate on the production hub; the operator deletes them + ## Desktop client — decided, not built (2026-08-17) See `docs/desktop-client-v1.md`. Nothing here is implemented; it is the design and the @@ -685,6 +707,7 @@ SFR residential Fedora 44 → meshbay.org OVH VPS: | Streamed download (browser) | `static/downloads.js` + `static/sw.js` | Needs the page *controlled*, and the worker confirms it served the request | | Leave a group (hub) | `meshbay_hub.api.groups` | `POST /v1/groups/{id}/leave` — self only; the owner is refused | | Public group cap (hub) | `meshbay_hub.api.groups` | `_check_public_group_quota` — 10 live public groups per owner, staff exempt. **Checked at creation only, because PATCH refuses to change visibility** | +| Uploads on/off (node) | `meshbay_node.roster` + `transport.webrtc_server` | `member_upload_allowed` / `set_member_upload`, gate in `_do_file_upload`. Per group, **operator-signed** (`OP_MEMBER_UPLOAD`), stored in `roster.db`, cached in the group context because the upload path is synchronous. **Absent means allowed** at every layer | | Node presence (hub) | `meshbay_hub.api.groups` | `node_online` on `/v1/groups/mine`, read from the signaling registry — no poll, no timer | | Chat paging (node) | `meshbay_node.chat.store` | `get_recent` / `get_before` / `has_before`. `get_messages` pages *forwards* and is not what a chat opens with | | Liveness (MNP) | `meshbay_common.protocol` | `PING`/`PONG` on an **already-open** channel; never for discovery — a handshake costs 0.6-7 s | -- cgit v1.2.3