From 11c039ed3f0dc2ecc5eb30512b3dafa647fc4520 Mon Sep 17 00:00:00 2001 From: Christophe Besson Date: Tue, 8 Sep 2026 03:04:49 +0200 Subject: feat(hub): cap a directory zip at 512 MB MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit An arbitrary ceiling, not a technical one: the zip writer streams and holds one chunk plus a record per file, so it would happily produce a hundred gigabytes. Past half a gigabyte the honest answer is a subfolder at a time, or the files individually. Enforced in file-utils.js's downloadDirectory, which is the one implementation behind every zip button — Files' single folder, Files' multi-folder selection, and the Photos album button (docs/photos.md §3). - Per directory, not per selection: Files zips a whole multi-directory selection in one click, so an oversized folder is refused and its siblings still download. - Before _openDownloadTarget, so no save dialog opens for an archive that is never going to be written. - The bound is strict, so a folder of exactly 512 MB still goes through. - Counted in the 1024-based units formatSize already prints, so the number in the refusal is the number in the constant. group.zip_too_large in all ten catalogues. test_zip_size_limit.py runs the module under Node and pins the refusal, the inclusive bound, and that nothing is asked or started when a folder is over. The user guide's "a 40 GB folder costs 40 GB of disk" is no longer true and now documents the cap instead. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01V8EDjk6pkYZrCbo63m2x87 --- docs/USERGUIDE.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'docs/USERGUIDE.md') diff --git a/docs/USERGUIDE.md b/docs/USERGUIDE.md index 32f31dd..3c0e30c 100644 --- a/docs/USERGUIDE.md +++ b/docs/USERGUIDE.md @@ -618,8 +618,13 @@ bell, with a progress bar, the current rate, and a cancel button each: Any member can take a whole folder: **⋮ → Download as zip** on the folder's row. The archive is built in the browser as the files arrive and written straight to -disk, so a 40 GB folder costs 40 GB of disk and a few megabytes of memory. +disk, so it costs disk space and only a few megabytes of memory. +- **A folder has to be 512 MB or smaller.** Larger than that and the button + refuses, naming the folder's size — take a subfolder at a time, or the files + individually. This is a deliberate cap, not a technical one: the writer would + happily stream a hundred gigabytes. Selecting several folders at once applies + it to each of them separately, so one oversized folder does not stop the rest. - Nothing is compressed. Group content is video, images and archives — already compressed — so deflating would spend CPU on every byte to save nothing, in the same thread that is decrypting. -- cgit v1.2.3