From 41d03f0a35a95daa7d54e7f29ab924776bedf6e4 Mon Sep 17 00:00:00 2001 From: Christophe Besson Date: Thu, 15 Oct 2026 17:42:30 +0200 Subject: fix(cli): make the command-line client work on Windows Its suite had only run on Linux. On Windows, against a real hub and node and from the installed meshbay-cli.exe: - secrets.enc was written in text mode (os.open without O_BINARY): every 0x0A of the ciphertext became CR LF and the saved session "does not open with its key" on the next run. - isatty() is true for NUL, so a script run with `< NUL` or by the Task Scheduler was asked questions instead of told to pass --yes; output.terminal() checks for a real console. - Ctrl+C waited for the selector loop's next timer, up to half a minute in `chat --follow`; the loop now points the signal wakeup at its self-pipe, as the proactor does. - Right-click copy and paste raised: asyncio cannot start a process on the selector loop; the clipboard tool runs in a thread. - Tab completion of remote paths ran on the default (proactor) loop, which never opens a node, and wrote in the locale encoding; the PowerShell script now reads it as UTF-8. - `get -R` into a folder past MAX_PATH died with a traceback; get, put, the resume file and the interactive mode use the extended form at each disk call, as the node does. - `groups` showed a SQLite hub's naive UTC time as local time. The opt-in end-to-end suite now runs on Windows (16 tests: Chrome found under Program Files and started with the real environment, VLC as the player, Ctrl+C through a console of its own, PowerShell 5.1 completion of an accented name). Co-Authored-By: Claude Opus 5.5 --- packages/meshbay-cli/src/meshbay_cli/tui/chat.py | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'packages/meshbay-cli/src/meshbay_cli/tui/chat.py') diff --git a/packages/meshbay-cli/src/meshbay_cli/tui/chat.py b/packages/meshbay-cli/src/meshbay_cli/tui/chat.py index e4ea1fe..989ffe2 100644 --- a/packages/meshbay-cli/src/meshbay_cli/tui/chat.py +++ b/packages/meshbay-cli/src/meshbay_cli/tui/chat.py @@ -21,6 +21,7 @@ import os import time from pathlib import Path +from meshbay_common.paths import long_path from rich.segment import Segment from rich.text import Text from textual import events @@ -412,9 +413,10 @@ class ChatRoomScreen(Screen): async def _put(self, arg: str) -> None: path = Path(os.path.abspath(os.path.expanduser(arg))) - if not path.is_file(): + if not os.path.isfile(long_path(path)): self.note(f"! {safe(arg)}: " + ("a folder; /put sends one file." - if path.is_dir() else "no such file."), style="bold red") + if os.path.isdir(long_path(path)) else "no such file."), + style="bold red") return name = path.name if problems := refused_names([name], []): @@ -430,9 +432,9 @@ class ChatRoomScreen(Screen): if found is None: return _, folder = found - size = path.stat().st_size + size = os.stat(long_path(path)).st_size advance, queued = self._progress("↑", name, size) - with open(path, "rb") as fh: + with open(long_path(path), "rb") as fh: def read(offset: int, length: int) -> bytes: fh.seek(offset) return fh.read(length) @@ -475,7 +477,8 @@ class ChatRoomScreen(Screen): style="bold red") return target = Path.cwd() / name.rsplit("/", 1)[-1] - if target.exists() and not target.with_name(target.name + PART_SUFFIX).exists(): + if os.path.exists(long_path(target)) and not os.path.exists( + long_path(target.with_name(target.name + PART_SUFFIX))): self.note(f"! {safe(str(target))} is here already; nothing was downloaded.", style="bold red") return -- cgit v1.2.3