From 95f14c1b30a8e28735881314947e6ca66f165161 Mon Sep 17 00:00:00 2001 From: Christophe Besson Date: Thu, 15 Oct 2026 17:57:27 +0200 Subject: test(cli): a Chrome that does not come up is not left running Its constructor gave up with the browser still running and no object to close it: eight headless Chrome processes were found hours after a failed Windows run. Co-Authored-By: Claude Opus 5.5 --- packages/meshbay-cli/tests/test_e2e_local.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'packages/meshbay-cli/tests/test_e2e_local.py') diff --git a/packages/meshbay-cli/tests/test_e2e_local.py b/packages/meshbay-cli/tests/test_e2e_local.py index b131658..85e5e85 100644 --- a/packages/meshbay-cli/tests/test_e2e_local.py +++ b/packages/meshbay-cli/tests/test_e2e_local.py @@ -781,7 +781,11 @@ class _Chrome: target = next(p for p in pages if p["type"] == "page") break except (httpx.HTTPError, StopIteration): - assert time.monotonic() < deadline, "Chrome did not come up" + if time.monotonic() > deadline: + # Not left running: nobody holds this object to close it. + self.proc.kill() + self.proc.wait(10) + raise AssertionError("Chrome did not come up") from None time.sleep(0.2) self.ws = connect(target["webSocketDebuggerUrl"], max_size=None) self.n = 0 -- cgit v1.2.3