From 13d145253a871ef47ef4344f90566eea21b994ab Mon Sep 17 00:00:00 2001 From: Christophe Besson Date: Fri, 4 Sep 2026 16:50:32 +0200 Subject: fix(client): Stop/Restart buttons and an autostart toggle on the Node page MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Root cause of both reports: node:service-status's `installed` field was winAutostartInstalled() -- whether the Startup-folder launcher exists -- not whether the daemon can be managed at all. The Node page gates Stop/Restart on `installed`, so with no autostart configured (the default -- nothing installs it automatically) those buttons silently never rendered, leaving only Start. A perfectly manageable daemon looked unmanageable because a different, unrelated setting was off. installed now reflects the actual daemon binary (findNodeBinary()), same definition node:installed already used; autostart moves to its own field carrying what installed used to mean. That field also fixes the other half: there was no way to turn autostart on except the CLI. NodeServicePanel now shows a toggle-switch next to Start/Stop/Restart, wired through a new platform.node.autostart (install/remove) that mirrors the existing service.* pattern -- the preload/main.js bridge (W3) was already there, just never called from the interface. English and French strings; other locales fall back to English per the project's own stated policy (test_locales.py's own docstring). Verified: node --check on every edited file; hub/node suites green (863 pass, 0 fail — pre-existing test_locales.py encoding failures on this Windows checkout are unrelated, reproduced identically on the clean tree). Co-Authored-By: Claude Sonnet 5 --- packages/meshbay-client/src/main.js | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) (limited to 'packages/meshbay-client/src') diff --git a/packages/meshbay-client/src/main.js b/packages/meshbay-client/src/main.js index 6c92531..b0505a9 100644 --- a/packages/meshbay-client/src/main.js +++ b/packages/meshbay-client/src/main.js @@ -898,10 +898,17 @@ function registerBridge() { ipcMain.handle('node:service-status', async () => { if (process.platform === 'win32') { // No Task Scheduler to ask "is it running" — probe the daemon itself. - const p = await probeNode(); + // `installed` used to be winAutostartInstalled(), which is wrong: it + // answers "does the Startup launcher exist", not "is there a daemon to + // manage". The Node page's Stop/Restart buttons are gated on + // `installed`, so with no autostart configured they silently vanished + // — the daemon was perfectly manageable, just not launchable at + // sign-in. `autostart` carries that state as its own field instead. + const [p, bin] = await Promise.all([probeNode(), findNodeBinary()]); return { supported: true, - installed: winAutostartInstalled(), + installed: Boolean(bin), + autostart: winAutostartInstalled(), activeState: p ? 'active' : 'inactive', subState: p ? 'running' : '', }; -- cgit v1.2.3