From d3ad243c4ae3a273f623bd5fc631e3266aa4d0e4 Mon Sep 17 00:00:00 2001
From: Christophe Besson <cbesson@gmail.com>
Date: Wed, 30 Sep 2026 11:49:56 +0200
Subject: fix: only the owner decides who hosts a group, and nobody is made a
 member unasked
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- hub: a node may host a group only if its account owns it or the owner
  approved that node (new `group_hosts`). Membership was the ceiling, and
  every member holds the group key, so any member's node could register as a
  host and be the one clients kept. A node claiming a group it may not host
  is recorded as a request; the owner is notified once and approves or
  refuses it (GET/POST/DELETE /v1/groups/{id}/hosts[/{node_id}]), which
  takes effect on a connected node at once.
- hub: an owner adding a username creates an invitation (new
  `group_invitations`), accepted or declined by the invitee
  (/v1/groups/invitations, /{id}/invitation/accept|decline). Until then the
  group is not listed, not dialled, not searched and not in any token.
  Invitation links, open joins and group creation still make members
  directly: they are the account's own act.
- hub: the MNP token names only the group it is minted for (group_id is now
  required), so a node operator no longer learns a member's other groups.
- SPA: invitations on the home page; invited people and host requests in
  the group's settings; the transport sends group_id. Ten catalogues.
- Browser probes for both screens, run in Chrome and Firefox.
- Design §5.2, §7.2, §7.3, AV32, AV33; protocol §6.3; user guide.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---
 .../src/meshbay_hub/static/group-settings.js       | 78 ++++++++++++++++++++++
 1 file changed, 78 insertions(+)

(limited to 'packages/meshbay-hub/src/meshbay_hub/static/group-settings.js')

diff --git a/packages/meshbay-hub/src/meshbay_hub/static/group-settings.js b/packages/meshbay-hub/src/meshbay_hub/static/group-settings.js
index fba8a0e..048f831 100644
--- a/packages/meshbay-hub/src/meshbay_hub/static/group-settings.js
+++ b/packages/meshbay-hub/src/meshbay_hub/static/group-settings.js
@@ -410,7 +410,14 @@ function GroupSettingsPanel({ groupId, group, token, transportRef, gekRef,
                              onAppDirectories, onRefreshIndex,
                              onPaired, onLeft }) {
   const [members, setMembers] = useState([]);
+  // Asked and not answered — the owner is the only one told (the hub leaves
+  // the field out for anyone else).
+  const [invited, setInvited] = useState([]);
   const [adminId, setAdminId] = useState('');
+  // Nodes other than the owner's that asked to serve this group, and what the
+  // owner answered. Only the owner reads it.
+  const [hosts, setHosts] = useState([]);
+  const [hostBusy, setHostBusy] = useState('');
   const [loading, setLoading] = useState(true);
   const [inviteUser, setInviteUser] = useState('');
   const [inviting, setInviting] = useState(false);
@@ -802,6 +809,7 @@ function GroupSettingsPanel({ groupId, group, token, transportRef, gekRef,
     hubFetch(`/v1/groups/${groupId}/members`, { token })
       .then(data => {
         setMembers(data.members || []);
+        setInvited(data.invited || []);
         setAdminId(data.admin_id || '');
       })
       .catch(() => {})
@@ -810,6 +818,30 @@ function GroupSettingsPanel({ groupId, group, token, transportRef, gekRef,
 
   useEffect(() => { loadMembers(); }, [loadMembers]);
 
+  const ownsGroup = Boolean(group && group.is_admin);
+  const loadHosts = useCallback(() => {
+    if (!ownsGroup) return;
+    hubFetch(`/v1/groups/${groupId}/hosts`, { token })
+      .then(data => setHosts(data.hosts || []))
+      .catch(() => setHosts([]));
+  }, [groupId, token, ownsGroup]);
+
+  useEffect(() => { loadHosts(); }, [loadHosts]);
+
+  const decideHost = useCallback(async (host, approve) => {
+    setHostBusy(host.node_id);
+    setError('');
+    try {
+      await hubFetch(`/v1/groups/${groupId}/hosts/${host.node_id}`,
+                     { method: approve ? 'POST' : 'DELETE', token });
+      loadHosts();
+    } catch (err) {
+      setError(err.message);
+    } finally {
+      setHostBusy('');
+    }
+  }, [groupId, token, loadHosts]);
+
   useEffect(() => {
     hubFetch('/v1/users/me/preferences', { token })
       .then(prefs => setInviteByEmail(prefs[INVITE_EMAIL_PREF] === 'true'))
@@ -1382,12 +1414,58 @@ function GroupSettingsPanel({ groupId, group, token, transportRef, gekRef,
                 </td>
               </tr>
             `)}
+            ${invited.map(m => html`
+              <tr key=${m.user_id}>
+                <td>${m.username}</td>
+                <td><span class="badge">${t('members.invited')}</span></td>
+                <td class="admin-actions">
+                  ${isAdmin && html`
+                    <button class="admin-btn danger" disabled=${removing === m.user_id}
+                      onClick=${async () => {
+                        if (!await ask(t('members.remove_confirm', { user: m.username }))) return;
+                        removeMember(m);
+                      }}>
+                      ${removing === m.user_id ? '...' : t('members.remove')}
+                    </button>
+                  `}
+                </td>
+              </tr>
+            `)}
           </tbody>
         </table>
         ${isAdmin && members.length > 1 && html`
           <p class="settings-hint">${t('members.remove_hint')}</p>
         `}
       </${CollapsibleSection}>
+
+      ${ownsGroup && html`
+        <${CollapsibleSection} title=${t('hosts.title')}>
+          <p class="settings-hint">${t('hosts.hint')}</p>
+          ${hosts.length === 0 && html`<p class="settings-hint">${t('hosts.none')}</p>`}
+          ${hosts.length > 0 && html`
+            <table class="admin-table">
+              <tbody>
+                ${hosts.map(h => html`
+                  <tr key=${h.node_id}>
+                    <td>${t('hosts.from', { name: h.username })}
+                      <br /><code class="node-key">${h.pk_node}</code></td>
+                    <td><span class="badge">${t(`hosts.status_${h.status}`)}</span>
+                      ${h.online && html` <span class="badge">${t('hosts.online')}</span>`}</td>
+                    <td class="admin-actions">
+                      ${h.status !== 'approved' && html`
+                        <button class="admin-btn" disabled=${hostBusy === h.node_id}
+                          onClick=${() => decideHost(h, true)}>${t('hosts.approve')}</button>`}
+                      ${h.status !== 'refused' && html`
+                        <button class="admin-btn danger" disabled=${hostBusy === h.node_id}
+                          onClick=${() => decideHost(h, false)}>${t('hosts.refuse')}</button>`}
+                    </td>
+                  </tr>
+                `)}
+              </tbody>
+            </table>
+          `}
+        </${CollapsibleSection}>
+      `}
     </div>
   `;
 }
-- 
cgit v1.2.3