From 11c039ed3f0dc2ecc5eb30512b3dafa647fc4520 Mon Sep 17 00:00:00 2001 From: Christophe Besson Date: Tue, 8 Sep 2026 03:04:49 +0200 Subject: feat(hub): cap a directory zip at 512 MB MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit An arbitrary ceiling, not a technical one: the zip writer streams and holds one chunk plus a record per file, so it would happily produce a hundred gigabytes. Past half a gigabyte the honest answer is a subfolder at a time, or the files individually. Enforced in file-utils.js's downloadDirectory, which is the one implementation behind every zip button — Files' single folder, Files' multi-folder selection, and the Photos album button (docs/photos.md §3). - Per directory, not per selection: Files zips a whole multi-directory selection in one click, so an oversized folder is refused and its siblings still download. - Before _openDownloadTarget, so no save dialog opens for an archive that is never going to be written. - The bound is strict, so a folder of exactly 512 MB still goes through. - Counted in the 1024-based units formatSize already prints, so the number in the refusal is the number in the constant. group.zip_too_large in all ten catalogues. test_zip_size_limit.py runs the module under Node and pins the refusal, the inclusive bound, and that nothing is asked or started when a folder is over. The user guide's "a 40 GB folder costs 40 GB of disk" is no longer true and now documents the cap instead. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01V8EDjk6pkYZrCbo63m2x87 --- packages/meshbay-hub/src/meshbay_hub/static/locales/nl.js | 2 ++ 1 file changed, 2 insertions(+) (limited to 'packages/meshbay-hub/src/meshbay_hub/static/locales/nl.js') diff --git a/packages/meshbay-hub/src/meshbay_hub/static/locales/nl.js b/packages/meshbay-hub/src/meshbay_hub/static/locales/nl.js index 7bee011..4b992ae 100644 --- a/packages/meshbay-hub/src/meshbay_hub/static/locales/nl.js +++ b/packages/meshbay-hub/src/meshbay_hub/static/locales/nl.js @@ -593,6 +593,8 @@ export default { 'group.zip_no_stream': 'Deze browser kan een download niet rechtstreeks naar schijf ' + 'schrijven, dus {name} ({size}) moet eerst in het geheugen worden opgebouwd. Bij ' + 'een groot archief kan dat mislukken. Doorgaan?', + 'group.zip_too_large': '"{name}" is {size} en een map kan alleen tot {limit} als zip worden ' + + 'gedownload. Neem één submap per keer, of de bestanden afzonderlijk.', 'group.rmdir': 'Map verwijderen', 'group.rmdir_confirm': 'De map "{name}" verwijderen? Ze moet leeg zijn.', 'group.rmdir_not_empty': 'Die map is niet leeg. Verwijder eerst wat erin staat — ' -- cgit v1.2.3