From 9f3445d03f106ee3ebd8b4b1bd546a08d9169af7 Mon Sep 17 00:00:00 2001 From: Christophe Besson Date: Mon, 21 Sep 2026 19:53:33 +0200 Subject: fix: ask in the page instead of native confirm/alert A native confirm() or alert() leaves the desktop client unable to type until the window is refocused. ask.js draws both in the page; the SPA test now bans all three browser dialogs. Co-Authored-By: Claude Opus 5 --- packages/meshbay-hub/src/meshbay_hub/static/playlist-menu.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'packages/meshbay-hub/src/meshbay_hub/static/playlist-menu.js') diff --git a/packages/meshbay-hub/src/meshbay_hub/static/playlist-menu.js b/packages/meshbay-hub/src/meshbay_hub/static/playlist-menu.js index 64d1c62..a65d26d 100644 --- a/packages/meshbay-hub/src/meshbay_hub/static/playlist-menu.js +++ b/packages/meshbay-hub/src/meshbay_hub/static/playlist-menu.js @@ -2,6 +2,7 @@ import { html, useState, useCallback, useEffect, } from './vendor/htm-preact.js'; import { t } from './i18n.js'; +import { ask } from './ask.js'; import { Icon } from './icon.js'; import { Menu, useMenu } from './menu.js'; import * as P from './playlists.js'; @@ -123,10 +124,9 @@ function PlaylistMenuButton({ userId, lists, reload, onPlayQueue, onSync, cached }, [userId, reload, say]); const deletePlaylist = useCallback(async (p) => { - // `confirm` and not a component: Electron implements it, a dozen places in - // this SPA already use it, and a deletion is a tombstone rather than - // something that can be undone from the interface. - if (!window.confirm(t('playlists.confirm_delete', { name: p.name }))) return; + // Asked first: a deletion is a tombstone rather than something that can be + // undone from the interface. + if (!await ask(t('playlists.confirm_delete', { name: p.name }))) return; await P.deletePlaylist(userId, p.id); await reload(); say(t('playlists.deleted', { name: p.name })); -- cgit v1.2.3