From d5442e3a335327b445d27d0f7e8798726ba20973 Mon Sep 17 00:00:00 2001 From: Christophe Besson Date: Thu, 10 Sep 2026 17:30:40 +0200 Subject: docs(code): drop the references to a plan file that no longer exists Seven comments pointed at sections of `~/next/improve-downloads.md`, which is not in the tree and not anywhere a reader of this repository can follow. Each now states the thing it was citing: why a paused transfer holds nothing, why the lease is taken after the save target and not before, why a chunk request marks a lease alive, where the leaseless bound's number comes from. The leaseless comment also said "two files at a time" three paragraphs under `MAX_LEASELESS_IN_FLIGHT = 12`, left behind when the bound was raised. A comment that contradicts the constant beside it is worse than no comment: one of them is wrong and the reader cannot tell which. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01AsoWC3GmhNdwVFomW3QjH3 --- packages/meshbay-hub/src/meshbay_hub/static/downloads.js | 5 +++-- packages/meshbay-hub/src/meshbay_hub/static/file-utils.js | 6 +++--- 2 files changed, 6 insertions(+), 5 deletions(-) (limited to 'packages/meshbay-hub/src') diff --git a/packages/meshbay-hub/src/meshbay_hub/static/downloads.js b/packages/meshbay-hub/src/meshbay_hub/static/downloads.js index c790394..9c23d3c 100644 --- a/packages/meshbay-hub/src/meshbay_hub/static/downloads.js +++ b/packages/meshbay-hub/src/meshbay_hub/static/downloads.js @@ -649,8 +649,9 @@ async function _attemptStreamedDownload(filename, size, attempt, // writing to the stream stalls that download where we cannot see it or // resume it, and an idle worker is terminated within seconds, taking the // stream with it. A pause button here would restart from zero, which is - // worse than not offering one. §6.5 of ~/next/improve-downloads.md records - // what giving Firefox and Safari a resumable target would cost. + // worse than not offering one. Offering Firefox and Safari a resumable + // target means a resumable sink of our own, which is a larger piece of work + // than the button it would enable. pausable: false, writable: { write: (bytes) => { lastWrite = Date.now(); return writer.write(bytes); }, diff --git a/packages/meshbay-hub/src/meshbay_hub/static/file-utils.js b/packages/meshbay-hub/src/meshbay_hub/static/file-utils.js index 99d9f9a..b732734 100644 --- a/packages/meshbay-hub/src/meshbay_hub/static/file-utils.js +++ b/packages/meshbay-hub/src/meshbay_hub/static/file-utils.js @@ -451,9 +451,9 @@ async function downloadEntry(transfers, transport, gek, entry) { }, // After the target, never before: a granted slot has to be taken up within - // the node's deadline, and opening a target can outlast it. See §8.1 of - // ~/next/improve-downloads.md — the other order was tried and cost two of - // three downloads. + // the node's deadline, and opening a target can outlast it — a Save As + // dialog waits for a person. Asking for the slot first loses it to the + // grant deadline while the dialog is open. makeLease: () => transport.openTransfer({ kind: 'download', bytes: entry.size, chunks: totalChunks }), -- cgit v1.2.3