From c2bc79f71c553f3c8e76c592715266c8469e583e Mon Sep 17 00:00:00 2001 From: Christophe Besson Date: Thu, 10 Sep 2026 10:29:12 +0200 Subject: feat(hub): pin the app controls while a library scrolls MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Files, Videos, Music and Photos are read by scrolling, and everything that steers that reading left with the first screenful. Three bands now pin under the navigation bar, in a group and on the Search page alike: the tab bar (the search field, on Search), the application's own toolbar, and the file table's column heads. The group's name and description still scroll — they say nothing a reader needs while walking a directory, and the height they would cost is height the list does not get. A band's offset is the heights of the bands above it, and those are not constants: the toolbar wraps to three rows on a phone, grows a field while a folder is being named, and loses its filter on Search. So each band measures itself and publishes `--chrome-h` / `--toolbar-h` (static/sticky.js) and the stylesheet does the arithmetic in calc(), rather than a number written down twice — the fault CLAUDE.md already records against this layout twice over. A band publishes height *plus its own bottom margin*, and paints that margin as a ring of page colour, so the pinned layout is pixel-identical to the flow layout and nothing shifts at the moment a band pins. Three overflow faults came out of it, all of the same class and all of them what "the header does not stay" actually meant on Android — a document wider than the screen leaves everything pinned attached to a viewport the reader can no longer see, the navigation bar included: - a directory's name cell was a bare , so an unbreakable folder name (`Rage_Against_The_Machine_Discography_1992-2000_FLAC`) set the column's minimum: a 527px table in a 390px window - Search's group column did the same at 442px with an underscored group name. It also goes entirely below 768px, where there is no room for it and the breadcrumb already names the group - the shared-directories table has four columns of controls with a combined minimum near 440px, none of it compressible. On a phone the row stops being a row: the name and its eject/remove pair on one line, the two switches — each carrying the column head's own string as a label — on the next - and, found by measuring at 360px, the tab bar itself was 19px too wide `.file-table` moves to separated borders: a collapsed border belongs to the table rather than to the cell, so the column heads lost their rule the moment they pinned. Measured, not read. tests/harness/sticky_header_probe.py drives the shipped GroupPage and SearchPage against a stub node, walks to each application, scrolls to the end and reports every rectangle — 11 views x 4 widths x 2 engines. Its fixture says what real data says: the first version used `note-007.txt` and `un groupe`, which fit any screen, and found none of the above. A fixture narrower than real data tests the fixture. Also: `test_desktop_shell` no longer looks for the CSP after the first `-->`, which made it fail on correct markup as soon as a comment was added above it, and `search-page.js` joins test_hook_ordering's file list. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01Tx16FhyD2BUdpooGb5jcyN --- .../tests/harness/sticky_header_probe.py | 563 +++++++++++++++++++++ 1 file changed, 563 insertions(+) create mode 100755 packages/meshbay-hub/tests/harness/sticky_header_probe.py (limited to 'packages/meshbay-hub/tests/harness') diff --git a/packages/meshbay-hub/tests/harness/sticky_header_probe.py b/packages/meshbay-hub/tests/harness/sticky_header_probe.py new file mode 100755 index 0000000..9e9dc3c --- /dev/null +++ b/packages/meshbay-hub/tests/harness/sticky_header_probe.py @@ -0,0 +1,563 @@ +#!/usr/bin/env python3 +""" +Does the header stay put? + +Files, Videos, Music and Photos pin three bands under the navigation bar — the +tab bar (the search field, on the Search page), the application's toolbar, and +the file table's column heads — so that scrolling a library never costs the +controls that steer it. Two of those offsets are `calc()` over a height +measured at runtime (sticky.js), which means the arrangement can be wrong in +ways no stylesheet reading finds: a band an inch too low leaves a stripe of +list showing through above it, a band too high hides the one over it, and a +toolbar that wraps to three rows on a phone moves the column heads by 96px +that nothing in the CSS knows about. + +So this scrolls. It renders the shipped `GroupPage` and `SearchPage` against a +stub node, walks to each application, scrolls the window down, and reports the +rectangle of every band before and after — at a desktop width and at a phone +width, where the toolbars wrap and the measurement earns its keep. + + sticky_header_probe.py + +Prints JSON: one object per case, each with `before` and `after` maps of +selector -> {top, bottom, height} in viewport coordinates, plus what the +window did. + +Chrome by default; `--engine firefox` runs the same cases in Firefox, which is +half of MeshBay's readers and has its own history with `position: sticky`. +""" +import argparse +import http.server +import json +import os +import socketserver +import subprocess +import sys +import tempfile +import threading +import time +from pathlib import Path + +STATIC = Path(__file__).resolve().parents[2] / "src" / "meshbay_hub" / "static" +PORT = 8751 +RECORDS = [] +socketserver.TCPServer.allow_reuse_address = True +# Set when every case has reported. Firefox needs it: it has no +# "navigate and stay open" headless mode that runs a page to completion, only +# `--screenshot`, which fires at the load event and exits. So each frame holds +# one image open, the load event waits for that image, and the image is +# answered here once the run is done. Chrome does not need it and does not get +# it. +FINISHED = threading.Event() + +# 1100 desktop; 420 is where the phone media query has been tuned; 390 is an +# actual handset, and the width the first report of a band not pinning at all +# came from; 360 is the small end of what is still sold, and it is where the +# settings table's two switches and its two buttons have the least room. +WIDTHS = [1100, 420, 390, 360] + +# The tab bar's buttons are the enabled apps in registry order, so Files is 1, +# Videos 2, Music 3, Photos 4 (Chat is 0, Settings last). The Search page's +# view toggle is files/videos/music/photos in that order. +GROUP_CASES = [ + ("group files", {"page": "group", "click": [".group-tabs .group-tab:nth-of-type(2)"], + "ready": ".file-toolbar", + "bands": [".group-tabs", ".file-toolbar", ".file-table th"], + "content": ".file-row"}), + # Inside a root, where the rows are the library's own folders. The report + # that started this came from there, not from the top level. + ("group files in a folder", {"page": "group", + # The second row, which is the music root: + # the first is `films`, whose folders are + # short and prove nothing. + "click": [".group-tabs .group-tab:nth-of-type(2)", + ".file-table tbody tr:nth-of-type(2)"], + "ready": ".file-toolbar", + "bands": [".group-tabs", ".file-toolbar", + ".file-table th"], + "content": ".file-row"}), + ("group videos", {"page": "group", "click": [".group-tabs .group-tab:nth-of-type(3)"], + "ready": ".video-toolbar", + "bands": [".group-tabs", ".video-toolbar"], + "content": ".video-tile-slot"}), + ("group music", {"page": "group", "click": [".group-tabs .group-tab:nth-of-type(4)"], + "ready": ".video-toolbar", + "bands": [".group-tabs", ".video-toolbar"], + "content": ".music-tile-slot"}), + ("group photos", {"page": "group", "click": [".group-tabs .group-tab:nth-of-type(5)"], + "ready": ".photo-toolbar", + "bands": [".group-tabs", ".photo-toolbar"], + "content": ".photo-album-tile-slot"}), + # An open album swaps the toolbar for its own title bar, which pins in the + # same place — the one band that is not a toolbar. + # The group's own Settings, as its operator sees it: the shared-directories + # table is four columns of controls, none of which can be squeezed, and it + # was the next thing to hang off the right of a phone. + ("group settings", {"page": "group", + "click": [".group-tabs .group-tab:nth-of-type(6)"], + "ready": ".shared-dirs-tbl", + "bands": [".group-tabs"], + "content": ".shared-dirs-tbl tbody tr"}), + ("group photo album", {"page": "group", + "click": [".group-tabs .group-tab:nth-of-type(5)", + ".photo-album-card"], + "ready": ".photo-album-bar", + "bands": [".group-tabs", ".photo-album-bar"], + "content": ".photo-tile-slot"}), + # Search's Files view opens on the list of groups, one folder per group — + # the rows are inside it. + ("search files", {"page": "search", "click": [".view-toggle button:nth-of-type(1)", + ".file-row.dir-row"], + "ready": ".file-toolbar", + "bands": [".search-bar", ".file-toolbar", ".file-table th"], + "content": ".file-row"}), + ("search videos", {"page": "search", "click": [".view-toggle button:nth-of-type(2)"], + "ready": ".video-toolbar", + "bands": [".search-bar", ".video-toolbar"], + "content": ".video-tile-slot"}), + ("search music", {"page": "search", "click": [".view-toggle button:nth-of-type(3)"], + "ready": ".video-toolbar", + "bands": [".search-bar", ".video-toolbar"], + "content": ".music-tile-slot"}), + # Photos on the Search page has no toolbar of its own: its only control is + # the filter, and the search field above it already is one. + ("search photos", {"page": "search", "click": [".view-toggle button:nth-of-type(4)"], + "ready": ".photo-album-grid", + "bands": [".search-bar"], + "content": ".photo-album-tile-slot"}), +] + +CASES = [(f"{name} @{w}", dict(spec, width=w, label=name)) + for w in WIDTHS for name, spec in GROUP_CASES] + +# The shell around the page under test: the real navigation bar (which is what +# every band pins beneath), the real sidebar, the real main column. Measuring a +# page mounted on a bare body would put every band at the top of the window and +# prove nothing about the offset. +SHELL = """ + +
+ +
+
+""" + +# Substituted by name, not by `%`-formatting: this template is JavaScript, +# and JavaScript has a modulo operator. `i % ARTISTS.length` in the fixture +# below made the whole page fail to render with "not enough arguments for +# format string", from inside a request handler, which reads as the probe +# measuring nothing rather than as a typo. +FRAME = r""" + + + +""" + +# Appended to every frame when the engine needs the load event held back. +HOLD = "" +HOLD_TAG = '' + +PAGE = r""" +
""" + + +def render_frame(index: int) -> str: + """One case's page: the shell around it and its own configuration.""" + cfg = dict(CASES[index][1], index=index) + return (FRAME.replace("", SHELL) + .replace("/*CFG*/", json.dumps(cfg)) + HOLD) + + +class H(http.server.BaseHTTPRequestHandler): + def log_message(self, *a): + pass + + def do_POST(self): + length = int(self.headers.get("Content-Length") or 0) + if self.path == "/log": + RECORDS.append(json.loads(self.rfile.read(length).decode())) + FINISHED.set() + else: + self.rfile.read(length) + self.send_response(204) + self.end_headers() + + def _send(self, body: bytes, ctype: str) -> None: + self.send_response(200) + self.send_header("Content-Type", ctype) + self.send_header("Content-Length", str(len(body))) + self.end_headers() + self.wfile.write(body) + + def do_GET(self): + path = self.path.split("?")[0] + if path == "/hold": + FINISHED.wait(120) + self._send(b"", "image/gif") + elif path == "/": + widths = [spec["width"] for _, spec in CASES] + self._send(PAGE.replace("/*CASES*/", json.dumps(widths)).encode(), + "text/html; charset=utf-8") + elif path == "/case": + index = int(self.path.split("n=")[1]) + self._send(render_frame(index).encode(), "text/html; charset=utf-8") + elif path == "/v1/groups/g1/nodes": + self._send(b'{"nodes": [{"node_id": "n1"}]}', "application/json") + else: + asset = (STATIC / path.lstrip("/")).resolve() + if not str(asset).startswith(str(STATIC)) or not asset.is_file(): + self.send_response(404) + self.end_headers() + return + self._send(asset.read_bytes(), + "text/css" if asset.suffix == ".css" + else "text/javascript" if asset.suffix == ".js" + else "application/octet-stream") + + +# Each engine gets the same page and reports through the same `/log` POST, so +# nothing here depends on a debugging protocol only one of them speaks. +ENGINES = { + "chrome": lambda profile, size: [ + "google-chrome", "--headless=new", "--disable-gpu", "--no-sandbox", + f"--user-data-dir={profile}", f"--window-size={size}"], + # Firefox has no headless mode that simply opens a page and waits, so it + # is driven through `--screenshot`: the picture is thrown away, the point + # is that the page runs and the load event is what ends the process. + # + # And it is isolated with `HOME`, not `--profile`: given `--profile` on a + # directory it has not initialised itself, this Firefox starts, prints its + # headless banner, and then never requests the URL at all — no error, no + # page, nothing to debug. Pointing HOME at a throwaway directory lets it + # create its own default profile there, which works and leaves the + # developer's real one alone. + "firefox": lambda profile, size: [ + "firefox", "--headless", + "--screenshot", str(Path(profile) / "shot.png"), + "--window-size", size], +} +# The environment each engine is launched with, on top of the current one. +ENGINE_ENV = {"firefox": lambda profile: {"HOME": profile}} +# Which engines need the load event held until the measurement is in. +HOLDS_LOAD = {"firefox"} + + +def main() -> int: + ap = argparse.ArgumentParser() + ap.add_argument("--engine", choices=sorted(ENGINES), default="chrome") + args = ap.parse_args() + launcher = ENGINES[args.engine] + global HOLD + HOLD = HOLD_TAG if args.engine in HOLDS_LOAD else "" + + with socketserver.ThreadingTCPServer(("127.0.0.1", PORT), H) as srv: + threading.Thread(target=srv.serve_forever, daemon=True).start() + # ignore_cleanup_errors for the same reason group_tab_probe.py gives: + # Chrome's children outlive terminate() by a moment and go on writing + # into the profile, and a throwaway profile is not worth a failed run. + with tempfile.TemporaryDirectory(ignore_cleanup_errors=True) as profile: + env = dict(os.environ, + **ENGINE_ENV.get(args.engine, lambda _p: {})(profile)) + proc = subprocess.Popen( + launcher(profile, "1200,900") + [f"http://127.0.0.1:{PORT}/"], + env=env, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL) + for _ in range(900): + if RECORDS: + break + time.sleep(0.1) + proc.terminate() + try: + proc.wait(timeout=10) + except subprocess.TimeoutExpired: + proc.kill() + proc.wait() + if not RECORDS: + print(json.dumps({"error": "no measurement"}), file=sys.stderr) + return 1 + by_case = {r["case"]: r for r in RECORDS[0]} + print(json.dumps( + [dict(name=CASES[i][0], engine=args.engine, width=CASES[i][1]["width"], + view=CASES[i][1]["label"], page=CASES[i][1]["page"], + bands=CASES[i][1]["bands"], content=CASES[i][1]["content"], + **by_case[i]) + for i in sorted(by_case)], indent=1)) + return 0 + + +if __name__ == "__main__": + raise SystemExit(main()) -- cgit v1.2.3