From 7422a777297347dc83e6c5b2e89c1a6fa99a36b0 Mon Sep 17 00:00:00 2001 From: Christophe Besson Date: Sun, 27 Sep 2026 22:21:07 +0200 Subject: fix(hub): say "No operator paired" only when the node says so The Node page showed the banner whenever operator_paired was not true, so a node that had not yet read its roster -- one still signing in to the hub -- was reported unpaired while its pairing was intact. The node now answers null until it knows; the page shows the banner for false only. Co-Authored-By: Claude Opus 5.5 --- .../meshbay-hub/tests/test_node_page_pairing.py | 48 ++++++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 packages/meshbay-hub/tests/test_node_page_pairing.py (limited to 'packages/meshbay-hub/tests/test_node_page_pairing.py') diff --git a/packages/meshbay-hub/tests/test_node_page_pairing.py b/packages/meshbay-hub/tests/test_node_page_pairing.py new file mode 100644 index 0000000..435488e --- /dev/null +++ b/packages/meshbay-hub/tests/test_node_page_pairing.py @@ -0,0 +1,48 @@ +""" +The Node page's "No operator paired" banner. + +A node publishes its roster only once it has signed in to the hub, and until +then it has no way to know who is paired. It used to answer `false` in that +window and the page took `!operator_paired` for "not paired" -- so a node stuck +waiting for its account told its operator to pair again, about a pairing that +was intact, and sent them after the wrong problem. +""" + +import json +import re +import shutil +import subprocess +from pathlib import Path + +import pytest + +STATIC = Path(__file__).resolve().parents[1] / "src" / "meshbay_hub" / "static" +NODE_PAGE = STATIC / "node-page.js" + + +def _source() -> str: + return NODE_PAGE.read_text(encoding="utf-8") + + +@pytest.mark.skipif(shutil.which("node") is None, reason="node is not available") +def test_paired_is_unknown_unless_the_node_says_true_or_false(tmp_path): + m = re.search(r"^export function pairedFrom\(.*?^\}", _source(), re.M | re.S) + assert m, "node-page.js no longer has pairedFrom" + script = tmp_path / "case.js" + cases = [{"operator_paired": True}, {"operator_paired": False}, + {"operator_paired": None}, {}, None, {"operator_paired": "yes"}] + script.write_text(m.group(0).replace("export ", "") + + f"\nconsole.log(JSON.stringify({json.dumps(cases)}.map(pairedFrom)));", + encoding="utf-8") + out = subprocess.run(["node", str(script)], capture_output=True, encoding="utf-8", check=True) + assert json.loads(out.stdout) == [True, False, None, None, None, None] + + +def test_the_banner_needs_an_explicit_false(): + src = _source() + banner = src.index('class="node-pair-banner"') + guard = src.rindex("${", 0, banner) + assert src[guard:banner].startswith("${operatorPaired === false &&"), ( + "the pairing banner must not show for a node that has not read its roster") + assert "useState(null)" in src.split("const [operatorPaired", 1)[1].split("\n", 1)[0] + assert "setOperatorPaired(!!" not in src -- cgit v1.2.3