From 914d2f0af848fb80d70d517901f44420a4e47764 Mon Sep 17 00:00:00 2001 From: Christophe Besson Date: Sat, 10 Oct 2026 13:13:57 +0200 Subject: feat(hub): delete a photo from the Photos app On a right-clicked tile and in the lightbox bar, after a confirmation, for the node's operator or the photo's uploader, as in Files. Co-Authored-By: Claude Opus 5.5 --- .../tests/harness/photo_delete_probe.py | 285 +++++++++++++++++++++ packages/meshbay-hub/tests/test_photo_delete.py | 60 +++++ 2 files changed, 345 insertions(+) create mode 100755 packages/meshbay-hub/tests/harness/photo_delete_probe.py create mode 100644 packages/meshbay-hub/tests/test_photo_delete.py (limited to 'packages/meshbay-hub/tests') diff --git a/packages/meshbay-hub/tests/harness/photo_delete_probe.py b/packages/meshbay-hub/tests/harness/photo_delete_probe.py new file mode 100755 index 0000000..a99566d --- /dev/null +++ b/packages/meshbay-hub/tests/harness/photo_delete_probe.py @@ -0,0 +1,285 @@ +#!/usr/bin/env python3 +""" +Deleting a photo from the Photos app, in a real browser. + +Mounts the shipped `PhotosApp` on a made-up index, with a transport that +records what it is asked to delete and an index that drops what was deleted, +as a node's does. Right-clicks a tile, picks Delete, answers the page's own +confirmation (ask.js) one way then the other, and does the same from the +lightbox's bar. + + photo_delete_probe.py + +Prints JSON: one entry per case. +""" + +import http.server +import json +import socketserver +import subprocess +import sys +import tempfile +import threading +import time +from pathlib import Path + +STATIC = Path(__file__).resolve().parents[2] / "src" / "meshbay_hub" / "static" +PORT = 8776 +RECORDS = [] +socketserver.TCPServer.allow_reuse_address = True + +FRAME = r""" + +

+""" + +PAGE = r""" +

""" + + +class H(http.server.BaseHTTPRequestHandler): + def log_message(self, *a): + pass + + def do_POST(self): + length = int(self.headers.get("Content-Length") or 0) + if self.path == "/log": + RECORDS.append(json.loads(self.rfile.read(length).decode())) + else: + self.rfile.read(length) + self.send_response(204) + self.end_headers() + + def _send(self, body: bytes, ctype: str) -> None: + self.send_response(200) + self.send_header("Content-Type", ctype) + self.send_header("Content-Length", str(len(body))) + self.end_headers() + self.wfile.write(body) + + def do_GET(self): + path = self.path.split("?")[0] + if path == "/": + self._send(PAGE.encode(), "text/html; charset=utf-8") + elif path == "/case": + self._send(FRAME.encode(), "text/html; charset=utf-8") + else: + asset = (STATIC / path.lstrip("/")).resolve() + if not str(asset).startswith(str(STATIC)) or not asset.is_file(): + self.send_response(404) + self.end_headers() + return + self._send(asset.read_bytes(), + "text/css" if asset.suffix == ".css" + else "text/javascript" if asset.suffix == ".js" + else "application/octet-stream") + + +def main() -> int: + with socketserver.TCPServer(("127.0.0.1", PORT), H) as srv: + threading.Thread(target=srv.serve_forever, daemon=True).start() + with tempfile.TemporaryDirectory(ignore_cleanup_errors=True) as profile: + proc = subprocess.Popen( + ["google-chrome", "--headless=new", "--disable-gpu", "--no-sandbox", + f"--user-data-dir={profile}", "--window-size=1100,900", + f"http://127.0.0.1:{PORT}/"], + stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL) + for _ in range(300): + if RECORDS: + break + time.sleep(0.1) + proc.terminate() + try: + proc.wait(timeout=10) + except subprocess.TimeoutExpired: + proc.kill() + proc.wait() + if not RECORDS: + print(json.dumps({"error": "no measurement"}), file=sys.stderr) + return 1 + print(json.dumps(RECORDS[0], indent=1)) + return 0 + + +if __name__ == "__main__": + raise SystemExit(main()) diff --git a/packages/meshbay-hub/tests/test_photo_delete.py b/packages/meshbay-hub/tests/test_photo_delete.py new file mode 100644 index 0000000..bcc943f --- /dev/null +++ b/packages/meshbay-hub/tests/test_photo_delete.py @@ -0,0 +1,60 @@ +""" +Deleting a photo from the Photos app (harness/photo_delete_probe.py). + +On a right-clicked tile and in the lightbox's bar, which is how a phone gets +at it. Offered on the rule Files applies and the node enforces: the node's +operator, or whoever uploaded the photo. Never without the page's own +confirmation, and never from Search, which is read-only. +""" + +import json +import shutil +import subprocess +import sys +from pathlib import Path + +import pytest + +HARNESS = Path(__file__).parent / "harness" / "photo_delete_probe.py" + + +@pytest.fixture(scope="module") +def cases(): + if shutil.which("google-chrome") is None: + pytest.skip("Chrome is not available") + proc = subprocess.run([sys.executable, str(HARNESS)], + capture_output=True, text=True, timeout=180) + assert proc.returncode == 0, f"probe failed: {proc.stdout}{proc.stderr}" + out = json.loads(proc.stdout) + assert "error" not in out, out["error"] + assert out["logs"] == [] + return {c["case"]: c for c in out["cases"]} + + +def test_ones_own_photo_is_deleted_only_once_confirmed(cases): + c = cases["tile"] + assert "Delete" in c["labels"] + assert c["asked"].startswith("Delete beach.jpg?") + assert c["after_no"] == {"deleted": 0, "tiles": 3} + assert c["deleted"] == [["p1", "sign-fn"]] + assert c["tiles"] == 2 + + +def test_somebody_elses_photo_offers_no_delete(cases): + assert "Delete" not in cases["not mine"]["menu_without_delete"] + + +def test_the_operator_may_delete_any_photo(cases): + assert cases["operator"]["delete_offered"] == [True, True, True] + + +def test_the_lightbox_deletes_and_shows_the_next_photo(cases): + c = cases["lightbox"] + assert c["button"] and c["dialog_on_top"] + assert c["deleted"] == ["p1"] + assert c["open"] and c["before"] == "beach.jpg" and c["after"] == "dunes.jpg" + + +def test_search_results_offer_no_delete(cases): + c = cases["read only"] + assert "Delete" not in c["labels"] and not c["lightbox_button"] -- cgit v1.2.3