From ab44526a291fa673aa2850d105f6412a70a5341f Mon Sep 17 00:00:00 2001
From: Christophe Besson <cbesson@gmail.com>
Date: Sun, 6 Sep 2026 19:03:22 +0200
Subject: feat(client): Phase 2 — per-app settings panes, folder tree,
 multi-directory
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Each app's settings were inlined in `group-settings.js` — TMDB, MusicBrainz,
and one folder picker per app, each with its own draft state and save handler
saying the same thing about a different key. They are one file per app now,
reached through the `apps.js` registry, and the page that renders them names no
application at all: adding one is a registry entry and a settings file.

The line between the two is what makes that true. What every app has — folders
— the page does generically, through one `saveDirectories` bound to the app.
What one app alone has, its pane does itself with the transport it is handed.
An app that only needs directories touches neither `group-settings.js` nor
`group-page.js`, which is `test_app_settings_plugin.py`'s subject.

`settings-ui.js` exists because a pane importing the page that renders it is a
cycle, and ES modules answer that with a temporal-dead-zone ReferenceError at
first render — a component that silently does not appear, the fault already
recorded in CLAUDE.md about hook ordering.

The flat depth-indented `<select>` of every folder in the library becomes a
modal tree. It asks the node for nothing: the tree is derived from paths the
client already holds, so it shows exactly what the group's index contains and
adds no folder-browsing protocol. For Chat's attachment folder — the one
directory that is written to rather than read — read-only roots are greyed
out, so the node's refusal arrives before the operator picks rather than when
somebody sends a file.

Videos and Music take a list of folders. A library on two drives could not be
described before; the only recourse was pointing the app at a parent containing
both, which pulls in everything else under it. The scalar shapes survive on the
wire alone, for a node speaking MNP 1.0, and the client reads them as a
one-element list.

Two things the tests caught that I would not have:

`test_asset_versioning` — six new modules were missing from `_ASSETS`. Reached
through the registry rather than imported by name, they are exactly the files
nothing else would notice changing, and a stale one is served from cache with
no version bump.

And `node --check foo.js` does **not** reliably report a module syntax error:
it accepted `${/* ... */''}` — htm template syntax pasted into a plain object
literal — and reported success. A `.mjs` copy forces the module parser and
reports it. The suite had no syntax check at all, which is how that reached a
file; `test_spa_syntax.py` does it for every module now, and pins that the
loose path is not what it uses.

Suite: 12 failures, all pre-existing.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011pvMdvLBG92jyhvD5pD6us
---
 packages/meshbay-node/src/meshbay_node/ui/app.py | 27 ++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

(limited to 'packages/meshbay-node/src/meshbay_node')

diff --git a/packages/meshbay-node/src/meshbay_node/ui/app.py b/packages/meshbay-node/src/meshbay_node/ui/app.py
index ef86ce3..130c59e 100644
--- a/packages/meshbay-node/src/meshbay_node/ui/app.py
+++ b/packages/meshbay-node/src/meshbay_node/ui/app.py
@@ -434,6 +434,33 @@ def create_ui_app(state: dict) -> FastAPI:
             raise HTTPException(400, "apps must be a non-empty list")
         return await _op(lambda: ops.set_enabled_apps(state, group_id, apps))
 
+    # ── App directories (operator only, localhost) ────────────────────────
+    #
+    # The loopback twin of the `app_directories` MNP op. One endpoint for every
+    # application, keyed by the app's own name, so adding one needs no route
+    # here — the same reason the op is generic. `ALLOWED_APPS` is checked on
+    # the MNP path; here the caller is already on localhost holding the run
+    # token, and `ops` refuses a directory outside the group's roots either
+    # way, so an unknown key writes one unread settings row and nothing else.
+
+    @app.put("/api/groups/{group_id}/app-directories/{app_key}")
+    async def set_app_directories(group_id: str, app_key: str, payload: dict):
+        dirs = payload.get("directories")
+        if not isinstance(dirs, list):
+            raise HTTPException(400, "directories must be a list")
+        return await _op(lambda: ops.set_app_directories(
+            state, group_id, app_key, [str(d) for d in dirs]))
+
+    @app.put("/api/groups/{group_id}/chat-directory")
+    async def set_chat_directory(group_id: str, payload: dict):
+        return await _op(lambda: ops.set_chat_directory(
+            state, group_id, str(payload.get("path") or "")))
+
+    @app.put("/api/groups/{group_id}/chat-link-preview")
+    async def set_chat_link_preview(group_id: str, payload: dict):
+        return await _op(lambda: ops.set_chat_link_preview(
+            state, group_id, bool(payload.get("enabled", True))))
+
     # ── Scan settings (operator only, localhost) ──────────────────────────
 
     @app.put("/api/groups/{group_id}/scan-settings")
-- 
cgit v1.2.3