From 13d145253a871ef47ef4344f90566eea21b994ab Mon Sep 17 00:00:00 2001 From: Christophe Besson Date: Fri, 4 Sep 2026 16:50:32 +0200 Subject: fix(client): Stop/Restart buttons and an autostart toggle on the Node page MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Root cause of both reports: node:service-status's `installed` field was winAutostartInstalled() -- whether the Startup-folder launcher exists -- not whether the daemon can be managed at all. The Node page gates Stop/Restart on `installed`, so with no autostart configured (the default -- nothing installs it automatically) those buttons silently never rendered, leaving only Start. A perfectly manageable daemon looked unmanageable because a different, unrelated setting was off. installed now reflects the actual daemon binary (findNodeBinary()), same definition node:installed already used; autostart moves to its own field carrying what installed used to mean. That field also fixes the other half: there was no way to turn autostart on except the CLI. NodeServicePanel now shows a toggle-switch next to Start/Stop/Restart, wired through a new platform.node.autostart (install/remove) that mirrors the existing service.* pattern -- the preload/main.js bridge (W3) was already there, just never called from the interface. English and French strings; other locales fall back to English per the project's own stated policy (test_locales.py's own docstring). Verified: node --check on every edited file; hub/node suites green (863 pass, 0 fail — pre-existing test_locales.py encoding failures on this Windows checkout are unrelated, reproduced identically on the clean tree). Co-Authored-By: Claude Sonnet 5 --- packages/meshbay-client/src/main.js | 11 +++++++++-- .../meshbay-hub/src/meshbay_hub/static/locales/en.js | 2 ++ .../meshbay-hub/src/meshbay_hub/static/locales/fr.js | 2 ++ .../meshbay-hub/src/meshbay_hub/static/node-page.js | 14 ++++++++++++++ .../meshbay-hub/src/meshbay_hub/static/platform.js | 19 +++++++++++++++++++ 5 files changed, 46 insertions(+), 2 deletions(-) (limited to 'packages') diff --git a/packages/meshbay-client/src/main.js b/packages/meshbay-client/src/main.js index 6c92531..b0505a9 100644 --- a/packages/meshbay-client/src/main.js +++ b/packages/meshbay-client/src/main.js @@ -898,10 +898,17 @@ function registerBridge() { ipcMain.handle('node:service-status', async () => { if (process.platform === 'win32') { // No Task Scheduler to ask "is it running" — probe the daemon itself. - const p = await probeNode(); + // `installed` used to be winAutostartInstalled(), which is wrong: it + // answers "does the Startup launcher exist", not "is there a daemon to + // manage". The Node page's Stop/Restart buttons are gated on + // `installed`, so with no autostart configured they silently vanished + // — the daemon was perfectly manageable, just not launchable at + // sign-in. `autostart` carries that state as its own field instead. + const [p, bin] = await Promise.all([probeNode(), findNodeBinary()]); return { supported: true, - installed: winAutostartInstalled(), + installed: Boolean(bin), + autostart: winAutostartInstalled(), activeState: p ? 'active' : 'inactive', subState: p ? 'running' : '', }; diff --git a/packages/meshbay-hub/src/meshbay_hub/static/locales/en.js b/packages/meshbay-hub/src/meshbay_hub/static/locales/en.js index 898f7f4..09feaf5 100644 --- a/packages/meshbay-hub/src/meshbay_hub/static/locales/en.js +++ b/packages/meshbay-hub/src/meshbay_hub/static/locales/en.js @@ -734,6 +734,8 @@ export default { 'node.service_stopping': 'Stopping…', 'node.service_restart': 'Restart', 'node.service_restarting': 'Restarting…', + 'node.autostart_label': 'Start automatically at sign-in', + 'node.autostart_updating': 'Updating…', 'node.offline': 'Node is offline', 'node.no_groups': 'No groups configured on this node.', 'node.retry': 'Retry', diff --git a/packages/meshbay-hub/src/meshbay_hub/static/locales/fr.js b/packages/meshbay-hub/src/meshbay_hub/static/locales/fr.js index 1999e7e..88e27f8 100644 --- a/packages/meshbay-hub/src/meshbay_hub/static/locales/fr.js +++ b/packages/meshbay-hub/src/meshbay_hub/static/locales/fr.js @@ -677,6 +677,8 @@ export default { 'node.service_stopping': 'Arrêt…', 'node.service_restart': 'Redémarrer', 'node.service_restarting': 'Redémarrage…', + 'node.autostart_label': 'Démarrer automatiquement à l\'ouverture de session', + 'node.autostart_updating': 'Mise à jour…', 'node.not_operator': 'Impossible de joindre votre node. Vérifiez qu\'il est en cours d\'exécution.', 'node.offline': 'Node hors ligne', 'node.retry': 'Réessayer', diff --git a/packages/meshbay-hub/src/meshbay_hub/static/node-page.js b/packages/meshbay-hub/src/meshbay_hub/static/node-page.js index a2d3e49..c619f6e 100644 --- a/packages/meshbay-hub/src/meshbay_hub/static/node-page.js +++ b/packages/meshbay-hub/src/meshbay_hub/static/node-page.js @@ -47,6 +47,12 @@ function NodeServicePanel({ onChanged }) { } }, [refresh, onChanged]); + const toggleAutostart = useCallback(() => { + act('autostart', () => (info && info.autostart + ? platform.node.autostart.remove() + : platform.node.autostart.install())); + }, [act, info]); + if (!platform.node.service.available) return null; if (!info || info.supported === false) { return html`
@@ -82,6 +88,14 @@ function NodeServicePanel({ onChanged }) { ${busy === 'restart' ? t('node.service_restarting') : t('node.service_restart')} `}
+ ${platform.node.autostart.available && typeof info.autostart === 'boolean' && html` + + `} `; } diff --git a/packages/meshbay-hub/src/meshbay_hub/static/platform.js b/packages/meshbay-hub/src/meshbay_hub/static/platform.js index 78e27eb..b1025c5 100644 --- a/packages/meshbay-hub/src/meshbay_hub/static/platform.js +++ b/packages/meshbay-hub/src/meshbay_hub/static/platform.js @@ -263,6 +263,25 @@ export const node = { return bridge.node.service.restart(); }, }, + /** + * Windows only: run the daemon at sign-in. `service.status()` already + * reports the current state as `autostart`; these two just flip it. + * `available` gates nothing platform-specific by itself — main.js answers + * `{ supported: false }` off Windows, same shape as `service`. + */ + autostart: { + available: Boolean(bridge && bridge.node && bridge.node.autostart), + async install() { + if (!bridge || !bridge.node || !bridge.node.autostart) + throw new Error('Node bridge not available'); + return bridge.node.autostart('install'); + }, + async remove() { + if (!bridge || !bridge.node || !bridge.node.autostart) + throw new Error('Node bridge not available'); + return bridge.node.autostart('remove'); + }, + }, }; /** -- cgit v1.2.3