From cc0820de8d8c33560c44bd6a0864de30e33a0109 Mon Sep 17 00:00:00 2001 From: Christophe Besson Date: Sat, 19 Sep 2026 01:15:53 +0200 Subject: docs: drop the references to design notes that live outside the repo MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Seventeen comments across the Windows packaging targets pointed at C:\Users\admin\devel\light-client.md and msix-installer.md -- absolute paths on one developer's machine, unreadable to anyone else who clones this repository and unverifiable by any test here. The surrounding prose already carried the substance in every case, so these are removals, not rewrites, with two exceptions where the pointer was doing real work: electron-builder.msix.yml's header told the reader to go read §4 and §8 first. It now states the fact directly (an AppX/MSIX install never elevates, by design, so the package carries none of installer.nsh's elevation logic) and says the open items are called out at each declaration below -- which they already were, at `capabilities` and `customExtensionsPath`. The two "msix-installer.md §8" citations become "an open item" / "the other open item", beside the description of the item that was already there. Paragraphs the removals left ragged are re-wrapped. Verified: node suite 1403 pass / 4 skip (71 of them test_packaging_win.py), both electron-builder configs still parse as YAML, node --check on main.js. The .ps1 edits are inside <# #> comment headers plus one deleted Write-Host in a block that keeps two others; no pwsh on this machine to parse them. Not touched, and much larger: ~230 comments elsewhere in the codebase cite per-feature design notes (musicbay.md, mediacenter.md, auth-confirm.md and twenty more) that were merged into docs/MESHBAY_DESIGN.md. Co-Authored-By: Claude Opus 5 --- packaging/win/build-win-msix.ps1 | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'packaging/win/build-win-msix.ps1') diff --git a/packaging/win/build-win-msix.ps1 b/packaging/win/build-win-msix.ps1 index 9f7f667..2aeb2b8 100644 --- a/packaging/win/build-win-msix.ps1 +++ b/packaging/win/build-win-msix.ps1 @@ -4,15 +4,14 @@ + ffmpeg), packaged for Microsoft Store submission instead of NSIS. .DESCRIPTION - See C:\Users\admin\devel\msix-installer.md for the plan this implements. Unlike Light, this target does NOT drop anything from Full's feature set -- it exists because Store certification of the NSIS "MSI/EXE" submission failed for a reason MSIX sidesteps entirely (an unsigned, internet-downloaded installer never gets a chance to run under - Microsoft's own unattended validation bot; see msix-installer.md §2), - not because the bundled node/service-mode/autostart machinery needed - removing. The one real change is *when* the two elevated operations - (firewall rule, service-mode install) can happen: an AppX/MSIX install + Microsoft's own unattended validation bot), not because the bundled + node/service-mode/autostart machinery needed removing. The one real + change is *when* the two elevated operations (firewall rule, + service-mode install) can happen: an AppX/MSIX install never elevates, so neither can run at install time the way build/installer.nsh's customInstall macro does. Both already have an elevation path that does not depend on the installer at all -- @@ -126,7 +125,6 @@ if ($pkg) { Write-Host "OK package: $($pkg.FullName)" -ForegroundColor Green Write-Host (" ({0:N0} MB)" -f ($pkg.Length / 1MB)) Write-Host " unsigned by design -- Microsoft signs it at publish time" -ForegroundColor DarkGray - Write-Host " (msix-installer.md 3)." -ForegroundColor DarkGray } else { Write-Host "!! no *.appx found in $Client\dist-msix" -ForegroundColor Red -- cgit v1.2.3