From cc0820de8d8c33560c44bd6a0864de30e33a0109 Mon Sep 17 00:00:00 2001 From: Christophe Besson Date: Sat, 19 Sep 2026 01:15:53 +0200 Subject: docs: drop the references to design notes that live outside the repo MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Seventeen comments across the Windows packaging targets pointed at C:\Users\admin\devel\light-client.md and msix-installer.md -- absolute paths on one developer's machine, unreadable to anyone else who clones this repository and unverifiable by any test here. The surrounding prose already carried the substance in every case, so these are removals, not rewrites, with two exceptions where the pointer was doing real work: electron-builder.msix.yml's header told the reader to go read §4 and §8 first. It now states the fact directly (an AppX/MSIX install never elevates, by design, so the package carries none of installer.nsh's elevation logic) and says the open items are called out at each declaration below -- which they already were, at `capabilities` and `customExtensionsPath`. The two "msix-installer.md §8" citations become "an open item" / "the other open item", beside the description of the item that was already there. Paragraphs the removals left ragged are re-wrapped. Verified: node suite 1403 pass / 4 skip (71 of them test_packaging_win.py), both electron-builder configs still parse as YAML, node --check on main.js. The .ps1 edits are inside <# #> comment headers plus one deleted Write-Host in a block that keeps two others; no pwsh on this machine to parse them. Not touched, and much larger: ~230 comments elsewhere in the codebase cite per-feature design notes (musicbay.md, mediacenter.md, auth-confirm.md and twenty more) that were merged into docs/MESHBAY_DESIGN.md. Co-Authored-By: Claude Opus 5 --- packaging/win/build-win-light.ps1 | 11 +++++------ packaging/win/build-win-msix.ps1 | 10 ++++------ packaging/win/electron-builder.light.yml | 3 --- packaging/win/electron-builder.msix.yml | 20 +++++++++----------- 4 files changed, 18 insertions(+), 26 deletions(-) (limited to 'packaging/win') diff --git a/packaging/win/build-win-light.ps1 b/packaging/win/build-win-light.ps1 index 5a8a06e..8b2d807 100644 --- a/packaging/win/build-win-light.ps1 +++ b/packaging/win/build-win-light.ps1 @@ -6,12 +6,11 @@ .DESCRIPTION The counterpart of build-win.ps1 (Full) for anyone who only wants to *use* MeshBay -- join groups, chat, browse, download, stream, cast -- - without ever hosting content from this machine. See - C:\Users\admin\devel\light-client.md for the evaluation this - implements: a member never needs a local node to begin with (identity - keys are per node -- the *host's* node, not the joiner's), so Light is - the existing browser-only usage pattern wrapped in the Electron shell, - minus the frozen meshbay-node.exe / ffmpeg / autostart bundle. + without ever hosting content from this machine. A member never needs a + local node to begin with (identity keys are per node -- the *host's* + node, not the joiner's), so Light is the existing browser-only usage + pattern wrapped in the Electron shell, minus the frozen + meshbay-node.exe / ffmpeg / autostart bundle. Steps 1-4 are identical to build-win.ps1 (build-win-common.ps1). Step 5, PyInstaller freezing a node runtime, does not happen at all -- that is diff --git a/packaging/win/build-win-msix.ps1 b/packaging/win/build-win-msix.ps1 index 9f7f667..2aeb2b8 100644 --- a/packaging/win/build-win-msix.ps1 +++ b/packaging/win/build-win-msix.ps1 @@ -4,15 +4,14 @@ + ffmpeg), packaged for Microsoft Store submission instead of NSIS. .DESCRIPTION - See C:\Users\admin\devel\msix-installer.md for the plan this implements. Unlike Light, this target does NOT drop anything from Full's feature set -- it exists because Store certification of the NSIS "MSI/EXE" submission failed for a reason MSIX sidesteps entirely (an unsigned, internet-downloaded installer never gets a chance to run under - Microsoft's own unattended validation bot; see msix-installer.md §2), - not because the bundled node/service-mode/autostart machinery needed - removing. The one real change is *when* the two elevated operations - (firewall rule, service-mode install) can happen: an AppX/MSIX install + Microsoft's own unattended validation bot), not because the bundled + node/service-mode/autostart machinery needed removing. The one real + change is *when* the two elevated operations (firewall rule, + service-mode install) can happen: an AppX/MSIX install never elevates, so neither can run at install time the way build/installer.nsh's customInstall macro does. Both already have an elevation path that does not depend on the installer at all -- @@ -126,7 +125,6 @@ if ($pkg) { Write-Host "OK package: $($pkg.FullName)" -ForegroundColor Green Write-Host (" ({0:N0} MB)" -f ($pkg.Length / 1MB)) Write-Host " unsigned by design -- Microsoft signs it at publish time" -ForegroundColor DarkGray - Write-Host " (msix-installer.md 3)." -ForegroundColor DarkGray } else { Write-Host "!! no *.appx found in $Client\dist-msix" -ForegroundColor Red diff --git a/packaging/win/electron-builder.light.yml b/packaging/win/electron-builder.light.yml index 155ffa6..502a3c5 100644 --- a/packaging/win/electron-builder.light.yml +++ b/packaging/win/electron-builder.light.yml @@ -10,9 +10,6 @@ # Invoked from packages/meshbay-client (see build-win-light.ps1), so every # relative path below resolves the same way package.json's `build` field's # already do. -# -# See C:\Users\admin\devel\light-client.md for the evaluation this -# implements. appId: org.meshbay.client.light productName: MeshBay Light diff --git a/packaging/win/electron-builder.msix.yml b/packaging/win/electron-builder.msix.yml index 5e45598..5460267 100644 --- a/packaging/win/electron-builder.msix.yml +++ b/packaging/win/electron-builder.msix.yml @@ -1,9 +1,8 @@ # Standalone electron-builder config for the "MSIX" Windows target: same # feature set as Full (bundled node + ffmpeg), packaged for Microsoft Store -# submission instead of NSIS. See C:\Users\admin\devel\msix-installer.md for -# the plan this implements -- read that first, especially §4 (why the -# installer can carry none of installer.nsh's elevation logic: an AppX/MSIX -# install never elevates, by design) and §8 (what is still unverified here). +# submission instead of NSIS. The package carries none of installer.nsh's +# elevation logic: an AppX/MSIX install never elevates, by design. What is +# still unverified here is called out at each declaration below. # # Deliberately NOT layered onto package.json's `build` field, same reasoning # as electron-builder.light.yml: --config reads ONLY this file, so nothing @@ -22,8 +21,8 @@ # windowsSignToolManager.js (computePublisherName), an AppX target built # with no certificate configured is logged as "Windows Store only build" and # left unsigned, with `publisher` written into the manifest as-is. Microsoft -# signs the package itself at publish time (msix-installer.md §3) -- signing -# it here first would be pointless work, not extra safety. +# signs the package itself at publish time -- signing it here first would be +# pointless work, not extra safety. appId: org.meshbay.client productName: MeshBay @@ -102,9 +101,9 @@ appx: # firewall.ps1's own rules, which are `-Profile Any` (private AND public # network). Whether Windows Firewall actually auto-exempts a full-trust # packaged app on the strength of these declarations -- eliminating the - # elevation firewall.ps1 exists for entirely -- is msix-installer.md §8's - # #1 open item: verify live before relying on it, the declaration alone - # only proves the manifest is well-formed. + # elevation firewall.ps1 exists for entirely -- is an open item: verify + # live before relying on it, the declaration alone only proves the + # manifest is well-formed. capabilities: - internetClientServer - privateNetworkClientServer @@ -116,7 +115,6 @@ appx: # switch to point it at a different bundled exe). build/appx-extensions.xml # declares that extension by hand for exactly this reason. Whether # Windows actually launches a *non-primary* bundled exe through this - # mechanism is the other open item in msix-installer.md §8 -- untested - # until sideloaded. + # mechanism is the other open item -- untested until sideloaded. customExtensionsPath: build/appx-extensions.xml showNameOnTiles: false -- cgit v1.2.3