aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristophe Besson <cbesson@gmail.com>2026-10-15 17:57:27 +0200
committerChristophe Besson <cbesson@gmail.com>2026-10-15 17:57:27 +0200
commit95f14c1b30a8e28735881314947e6ca66f165161 (patch)
treeb0f2912b6d28ac7326cbf13f92bbe862496639ff
parent63aa0ddd8c0ec49fe8b52b6b486b079887ed3112 (diff)
downloadmeshbay-95f14c1b30a8e28735881314947e6ca66f165161.tar.gz
test(cli): a Chrome that does not come up is not left runningHEAD0.20main
Its constructor gave up with the browser still running and no object to close it: eight headless Chrome processes were found hours after a failed Windows run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
-rw-r--r--packages/meshbay-cli/tests/test_e2e_local.py6
1 files changed, 5 insertions, 1 deletions
diff --git a/packages/meshbay-cli/tests/test_e2e_local.py b/packages/meshbay-cli/tests/test_e2e_local.py
index b131658..85e5e85 100644
--- a/packages/meshbay-cli/tests/test_e2e_local.py
+++ b/packages/meshbay-cli/tests/test_e2e_local.py
@@ -781,7 +781,11 @@ class _Chrome:
target = next(p for p in pages if p["type"] == "page")
break
except (httpx.HTTPError, StopIteration):
- assert time.monotonic() < deadline, "Chrome did not come up"
+ if time.monotonic() > deadline:
+ # Not left running: nobody holds this object to close it.
+ self.proc.kill()
+ self.proc.wait(10)
+ raise AssertionError("Chrome did not come up") from None
time.sleep(0.2)
self.ws = connect(target["webSocketDebuggerUrl"], max_size=None)
self.n = 0