diff options
| author | Christophe Besson <cbesson@gmail.com> | 2026-09-03 09:47:32 +0200 |
|---|---|---|
| committer | Christophe Besson <cbesson@gmail.com> | 2026-09-03 09:47:32 +0200 |
| commit | dd671eb3647801317736327ab5b7cbfaa05d3866 (patch) | |
| tree | 443623deb915434609f74228be552146a847afd7 /docs/first-review.md | |
| parent | 06dd82aeaeb3a800a72e8f14777cb6a7026b6690 (diff) | |
| download | meshbay-dd671eb3647801317736327ab5b7cbfaa05d3866.tar.gz | |
chore(client): declare author and homepage in the client package.json
electron-builder warned `author is missed in the package.json` on every
build, including the `--dir` one build-client.sh runs, and refused the
deb/rpm targets outright over it and over a missing homepage. Both were
pre-existing — builder 25 emitted the identical warning — and had simply
never been hit, because those targets had never been built.
The values are copied verbatim from packaging/deb/meshbay-client/DEBIAN/
control, which already declared them, so the two cannot disagree.
Not added: `desktopName`, despite the warning that asks for it. The path
this project actually ships (build-client.sh + packaging/desktop/
meshbay.desktop) already sets StartupWMClass=MeshBay, and src/main.js
sets --class to match for dev runs. The warning concerns the .desktop
electron-builder generates for its own deb/rpm targets, which is not what
gets installed.
That is the larger thing found here and left open: `npm run dist` defines
a second, incompatible layout for a package of the same name —
/opt/MeshBay/meshbay-client against /opt/meshbay-client/meshbay. See
~/next/npm-audit.md §9.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AbwJDbNTkiRUh7HTWEoyss
Diffstat (limited to 'docs/first-review.md')
0 files changed, 0 insertions, 0 deletions