diff options
| author | Christophe Besson <cbesson@gmail.com> | 2026-10-15 17:42:30 +0200 |
|---|---|---|
| committer | Christophe Besson <cbesson@gmail.com> | 2026-10-15 17:45:41 +0200 |
| commit | 41d03f0a35a95daa7d54e7f29ab924776bedf6e4 (patch) | |
| tree | 2e631013746f913413b9811562b9c9a4734a0e41 /packages/meshbay-cli/src/meshbay_cli/tui/screens.py | |
| parent | 39cac2878de059992cb09a1ccf09b6bcece99fae (diff) | |
| download | meshbay-41d03f0a35a95daa7d54e7f29ab924776bedf6e4.tar.gz | |
fix(cli): make the command-line client work on Windows
Its suite had only run on Linux. On Windows, against a real hub and node and
from the installed meshbay-cli.exe:
- secrets.enc was written in text mode (os.open without O_BINARY): every 0x0A
of the ciphertext became CR LF and the saved session "does not open with
its key" on the next run.
- isatty() is true for NUL, so a script run with `< NUL` or by the Task
Scheduler was asked questions instead of told to pass --yes;
output.terminal() checks for a real console.
- Ctrl+C waited for the selector loop's next timer, up to half a minute in
`chat --follow`; the loop now points the signal wakeup at its self-pipe,
as the proactor does.
- Right-click copy and paste raised: asyncio cannot start a process on the
selector loop; the clipboard tool runs in a thread.
- Tab completion of remote paths ran on the default (proactor) loop, which
never opens a node, and wrote in the locale encoding; the PowerShell script
now reads it as UTF-8.
- `get -R` into a folder past MAX_PATH died with a traceback; get, put, the
resume file and the interactive mode use the extended form at each disk
call, as the node does.
- `groups` showed a SQLite hub's naive UTC time as local time.
The opt-in end-to-end suite now runs on Windows (16 tests: Chrome found under
Program Files and started with the real environment, VLC as the player, Ctrl+C
through a console of its own, PowerShell 5.1 completion of an accented name).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Diffstat (limited to 'packages/meshbay-cli/src/meshbay_cli/tui/screens.py')
| -rw-r--r-- | packages/meshbay-cli/src/meshbay_cli/tui/screens.py | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/packages/meshbay-cli/src/meshbay_cli/tui/screens.py b/packages/meshbay-cli/src/meshbay_cli/tui/screens.py index 0306325..39b5df3 100644 --- a/packages/meshbay-cli/src/meshbay_cli/tui/screens.py +++ b/packages/meshbay-cli/src/meshbay_cli/tui/screens.py @@ -14,9 +14,11 @@ the node's operator) or none is, then asked once for the batch. import asyncio import contextlib +import os import threading from pathlib import Path +from meshbay_common.paths import long_path from rich.text import Text from textual.app import ComposeResult from textual.binding import Binding @@ -214,8 +216,8 @@ class MainScreen(Screen): problems.append(str(e)) for p in problems: self.app.notify(p, severity="warning", markup=False) - existing = [t for _, t in plan if t.exists() - and not t.with_name(t.name + PART_SUFFIX).exists()] + existing = [t for _, t in plan if os.path.exists(long_path(t)) + and not os.path.exists(long_path(t.with_name(t.name + PART_SUFFIX)))] overwrite = False if existing: names = ", ".join(safe(t.name) for t in existing[:5]) + ( @@ -229,7 +231,7 @@ class MainScreen(Screen): if not overwrite: plan = [(e, t) for e, t in plan if t not in existing] for d in dirs: - await asyncio.to_thread(d.mkdir, parents=True, exist_ok=True) + await asyncio.to_thread(os.makedirs, long_path(d), exist_ok=True) remote.marks.clear() remote.redraw() session = await self.pool.session(group) @@ -320,7 +322,7 @@ class MainScreen(Screen): self.strip.update_job(job, state="running") lock = threading.Lock() try: - with open(item.local, "rb") as fh: + with open(long_path(item.local), "rb") as fh: def read(offset: int, length: int) -> bytes: with lock: fh.seek(offset) |