diff options
| author | Christophe Besson <cbesson@gmail.com> | 2026-09-04 15:36:53 +0200 |
|---|---|---|
| committer | Christophe Besson <cbesson@gmail.com> | 2026-09-04 15:36:53 +0200 |
| commit | 74941aae5451c03a296413710fe888b1924e8c27 (patch) | |
| tree | 8dda07ea4f7c909122650a829447b871ca5b0997 /packages/meshbay-client/package.json | |
| parent | d04b915580c8ba05beb0943a6fab9b04e12294e4 (diff) | |
| download | meshbay-74941aae5451c03a296413710fe888b1924e8c27.tar.gz | |
feat(packaging): offer one elevated firewall step instead of two dialogs
Installing used to mean clicking through two separate Windows "Allow
access" prompts later — one for MeshBay.exe, one for meshbay-node.exe —
each confusing on its own and worse before the exe carried a version
resource. Adding a firewall rule needs admin, and the installer is
deliberately per-user with no elevation, so this can only ever be opt-in.
packaging/win/firewall.ps1 (new, shipped as an extraResource at
resources\firewall.ps1): idempotent add/remove of the two inbound UDP
rules ("MeshBay", "MeshBay Node"), grouped, logged to
%TEMP%\meshbay-firewall.log. Locates both executables from its own path,
no arguments needed beyond the action.
build/installer.nsh: customInstall asks "Allow MeshBay through Windows
Firewall now?" and runs firewall.ps1 via NSIS ExecShellWait "runas" — one
UAC prompt — only when not ${Silent}; declining or dismissing UAC falls
back to Windows' own per-process prompts, unchanged. customUnInstall
offers the same in reverse, defaulted to No (a stale rule for a deleted
exe is inert, so this should not nag on the way out) and skipped for a
silent uninstall.
Verified: rebuilt MeshBay-Setup-0.1.0.exe (electron-builder compiles the
new LogicLib.nsh / ExecShellWait NSIS successfully); firewall.ps1 run
unelevated fails cleanly into its log ("Access is denied") rather than
silently doing nothing, confirming the fallback path. Node suite 835
pass / 25 skip.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Diffstat (limited to 'packages/meshbay-client/package.json')
| -rw-r--r-- | packages/meshbay-client/package.json | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/packages/meshbay-client/package.json b/packages/meshbay-client/package.json index 57acff8..7f5afcb 100644 --- a/packages/meshbay-client/package.json +++ b/packages/meshbay-client/package.json @@ -33,6 +33,10 @@ "from": "node-runtime", "to": "node-runtime", "filter": ["**/*"] + }, + { + "from": "../../packaging/win/firewall.ps1", + "to": "firewall.ps1" } ] }, |