aboutsummaryrefslogtreecommitdiffstats
path: root/packages/meshbay-hub/tests/test_downloads.py
diff options
context:
space:
mode:
authorChristophe Besson <cbesson@gmail.com>2026-08-15 17:23:10 +0200
committerChristophe Besson <cbesson@gmail.com>2026-08-15 17:23:10 +0200
commitdd3927a661273734493f65a593755b95aecf5f09 (patch)
treeb40b9a0939e79c65990f4664211025b032c9bafa /packages/meshbay-hub/tests/test_downloads.py
parent4066c754a613deb965472853fe69727d68be593e (diff)
downloadmeshbay-dd3927a661273734493f65a593755b95aecf5f09.tar.gz
feat(groups): remove a member, and keep gigabytes out of the tab
**Removing a member.** The owner can do it from the Members tab, and it is two halves in the order that fails safe: the node stops serving the group key first (an operator-signed request, so a paired browser only), then the hub drops the membership row. The other order would leave someone able to reach a node that still serves them. It is a membership, not an account. The user row is never written: their other groups, their files and their pinned identity survive, because one group's owner must not be able to erase someone from the hub. It is also per group — a node hosting two loses them from one — and it does not take back the key they already unwrapped, which is what rotating the GEK is for. The confirmation and the panel both say so. **Downloads and streaming through the disk, in both browsers.** The audit this started as found two ways to put gigabytes in a tab. Firefox and Safari have no File System Access API, so every download there was collected in memory. A service worker fixes it: the page keeps the writable half of a transferred stream, the worker answers a made-up URL with the readable half and a Content-Disposition header, and the browser writes it to disk as it arrives, with real backpressure. The worker caches nothing and falls through on every request that is not one of these downloads. A zip announces no Content-Length, since the archive is larger than the files in it and a length we miss truncates the file. Video was worse and affected both browsers. The node pushed ffmpeg's whole output as fast as it was produced while the player consumed a segment at a time, so the queue held the film — and appending all of it hit the SourceBuffer's cap, where the handler logged the error and dropped the segment, leaving a hole in the middle of the film with nothing to show for it. Streaming is credit-based now, 24 segments of 256 KB in flight, verified against the live node: three credits, three segments, then silence until more are granted. The player evicts what is more than a minute behind the playhead and retries a refused segment rather than dropping it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Diffstat (limited to 'packages/meshbay-hub/tests/test_downloads.py')
-rw-r--r--packages/meshbay-hub/tests/test_downloads.py56
1 files changed, 56 insertions, 0 deletions
diff --git a/packages/meshbay-hub/tests/test_downloads.py b/packages/meshbay-hub/tests/test_downloads.py
index cd0cded..41d61bf 100644
--- a/packages/meshbay-hub/tests/test_downloads.py
+++ b/packages/meshbay-hub/tests/test_downloads.py
@@ -108,3 +108,59 @@ def test_the_open_action_reads_the_file_back(tmp_path):
target = src[src.index("export async function openTarget"):]
assert "getFile()" in target and "window.open(" in target
assert "revokeObjectURL" in target, "the blob URL must not be leaked"
+
+
+# ── Streaming to disk without the File System Access API ────────────────────
+
+SW = STATIC / "sw.js"
+
+
+def test_the_worker_only_answers_its_own_urls():
+ """
+ It is registered at the root scope, so it sees every request the page makes.
+ Anything that is not a download of ours has to fall through untouched — a
+ service worker that answers more than it should is a cache bug waiting to
+ happen.
+ """
+ src = SW.read_text()
+ assert "startsWith(PREFIX)" in src
+ assert "self.location.origin" in src, "cross-origin requests must fall through"
+ # The API, not the word: the file explains in prose that it caches nothing.
+ for api in ("caches.open", "caches.match", "cache.put"):
+ assert api not in src, f"this worker must not cache anything ({api})"
+
+
+def test_the_download_is_announced_as_an_attachment():
+ src = SW.read_text()
+ assert "Content-Disposition" in src and "attachment" in src
+ assert "filename*=UTF-8''" in src, "a name with accents would be mangled"
+ assert "Content-Length" in src
+
+
+def test_a_length_is_only_promised_when_it_is_known(tmp_path):
+ """
+ An archive is assembled as it goes and is larger than the files in it.
+ Announcing the sum of their sizes would truncate the download at that mark.
+ """
+ src = SW.read_text()
+ assert "if (entry.size > 0)" in src
+
+ app = (STATIC / "app.js").read_text()
+ zip_call = app[app.index("const target = await _openDownloadTarget(suggested"):]
+ zip_call = zip_call[:zip_call.index(");") + 2]
+ assert zip_call.rstrip().endswith(", 0);"), (
+ "the zip download announces a Content-Length it will not match")
+
+
+def test_backpressure_is_real(tmp_path):
+ """
+ The point of the service worker path is not holding the file. A stream that
+ is transferred gives `writer.write()` something to wait on; posting chunks
+ to a port would queue them in memory and look identical from here.
+ """
+ src = DOWNLOADS.read_text()
+ fn = src[src.index("export async function openStreamedDownload"):]
+ assert "new TransformStream()" in fn
+ assert "[readable]" in fn, "the readable half must be transferred, not copied"
+ assert "writer.write(bytes)" in fn
+ assert "return null" in fn, "a browser that cannot transfer streams must say so"