diff options
| author | Christophe Besson <cbesson@gmail.com> | 2026-09-06 19:03:22 +0200 |
|---|---|---|
| committer | Christophe Besson <cbesson@gmail.com> | 2026-09-06 19:03:22 +0200 |
| commit | ab44526a291fa673aa2850d105f6412a70a5341f (patch) | |
| tree | 5940f18acfc15fc732eb65d90de346920461b8c8 /packages/meshbay-hub/tests/test_search_media_merge.py | |
| parent | 85a2ec47b7ad334208a3dbb091fadccc7631785c (diff) | |
| download | meshbay-ab44526a291fa673aa2850d105f6412a70a5341f.tar.gz | |
feat(client): Phase 2 — per-app settings panes, folder tree, multi-directory
Each app's settings were inlined in `group-settings.js` — TMDB, MusicBrainz,
and one folder picker per app, each with its own draft state and save handler
saying the same thing about a different key. They are one file per app now,
reached through the `apps.js` registry, and the page that renders them names no
application at all: adding one is a registry entry and a settings file.
The line between the two is what makes that true. What every app has — folders
— the page does generically, through one `saveDirectories` bound to the app.
What one app alone has, its pane does itself with the transport it is handed.
An app that only needs directories touches neither `group-settings.js` nor
`group-page.js`, which is `test_app_settings_plugin.py`'s subject.
`settings-ui.js` exists because a pane importing the page that renders it is a
cycle, and ES modules answer that with a temporal-dead-zone ReferenceError at
first render — a component that silently does not appear, the fault already
recorded in CLAUDE.md about hook ordering.
The flat depth-indented `<select>` of every folder in the library becomes a
modal tree. It asks the node for nothing: the tree is derived from paths the
client already holds, so it shows exactly what the group's index contains and
adds no folder-browsing protocol. For Chat's attachment folder — the one
directory that is written to rather than read — read-only roots are greyed
out, so the node's refusal arrives before the operator picks rather than when
somebody sends a file.
Videos and Music take a list of folders. A library on two drives could not be
described before; the only recourse was pointing the app at a parent containing
both, which pulls in everything else under it. The scalar shapes survive on the
wire alone, for a node speaking MNP 1.0, and the client reads them as a
one-element list.
Two things the tests caught that I would not have:
`test_asset_versioning` — six new modules were missing from `_ASSETS`. Reached
through the registry rather than imported by name, they are exactly the files
nothing else would notice changing, and a stale one is served from cache with
no version bump.
And `node --check foo.js` does **not** reliably report a module syntax error:
it accepted `${/* ... */''}` — htm template syntax pasted into a plain object
literal — and reported success. A `.mjs` copy forces the module parser and
reports it. The suite had no syntax check at all, which is how that reached a
file; `test_spa_syntax.py` does it for every module now, and pins that the
loose path is not what it uses.
Suite: 12 failures, all pre-existing.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011pvMdvLBG92jyhvD5pD6us
Diffstat (limited to 'packages/meshbay-hub/tests/test_search_media_merge.py')
| -rw-r--r-- | packages/meshbay-hub/tests/test_search_media_merge.py | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/packages/meshbay-hub/tests/test_search_media_merge.py b/packages/meshbay-hub/tests/test_search_media_merge.py index 0312c57..65f85aa 100644 --- a/packages/meshbay-hub/tests/test_search_media_merge.py +++ b/packages/meshbay-hub/tests/test_search_media_merge.py @@ -71,12 +71,12 @@ def pipeline(): return "\n".join([ "const t = (k) => k;", EXPORT.sub("", MERGE.read_text()), - _block(VIDEO_APP, "function underVideoRoot(entry, videoRoot) {"), + _block(VIDEO_APP, "function underVideoRoot(entry, directories) {"), _block(VIDEO_APP, "function buildSeasons(episodes) {"), - _block(VIDEO_APP, "function groupVideoEntries(entries, videoRoot) {"), + _block(VIDEO_APP, "function groupVideoEntries(entries, videoDirectories) {"), _block(MUSIC_APP, "function foldKey(s) {"), - _block(MUSIC_APP, "function underAudioRoot(entry, audioRoot) {"), - _block(MUSIC_APP, "function groupMusicEntries(entries, audioRoot) {"), + _block(MUSIC_APP, "function underAudioRoot(entry, directories) {"), + _block(MUSIC_APP, "function groupMusicEntries(entries, musicDirectories) {"), _block(PHOTOS_APP, "function underAnyPhotoRoot(entry, photoRoots) {"), _block(PHOTOS_APP, "function groupPhotoAlbums(entries, photoRoots) {"), _const("SEARCH_VIDEO_ROOT"), @@ -107,7 +107,7 @@ def _grid(tmp_path, pipeline, entries, salt="reader", local=()): salt: {json.dumps(salt)}, isLocal: (g) => local.has(g), }}); - const {{ movies, shows }} = groupVideoEntries(merged, SEARCH_VIDEO_ROOT); + const {{ movies, shows }} = groupVideoEntries(merged, [SEARCH_VIDEO_ROOT]); console.log(JSON.stringify({{ movies: movies.map((e) => ({{ id: e.id, title: e.display_title || e.name, groupId: e.groupId, @@ -136,7 +136,7 @@ def _albums(tmp_path, pipeline, entries, salt="reader", local=()): salt: {json.dumps(salt)}, isLocal: (g) => local.has(g), }}); - const {{ albums, tracks }} = groupMusicEntries(merged, SEARCH_AUDIO_ROOT); + const {{ albums, tracks }} = groupMusicEntries(merged, [SEARCH_AUDIO_ROOT]); console.log(JSON.stringify({{ albums: albums.map((a) => ({{ artist: a.artist, album: a.album, |