aboutsummaryrefslogtreecommitdiffstats
path: root/packages/meshbay-hub/tests/test_spa_imports.py
diff options
context:
space:
mode:
authorChristophe Besson <cbesson@gmail.com>2026-09-07 10:35:09 +0200
committerChristophe Besson <cbesson@gmail.com>2026-09-07 10:35:09 +0200
commit2c0903c648e24b4e2adf20492398e8b67d033b49 (patch)
tree0435f298010f0f946362f28baebbe88337ca8768 /packages/meshbay-hub/tests/test_spa_imports.py
parent0ed078c92cabab1dab0f70f321562032ea549ce6 (diff)
parenteeda274d751c537f4ecef3087994a16a9517478f (diff)
downloadmeshbay-2c0903c648e24b4e2adf20492398e8b67d033b49.tar.gz
Merge branch 'refactor/groups-phase1'
Groups refactor, phases 1-3. The root model replaces the old `upload` flag and group-wide `member_upload` with per-root `writable`/`removable`/`ejected`, carried by a `RootSet` that both front doors — the loopback API and signed MNP — reach through the same `ops` functions. MNP goes to 1.1, additively: the roots table now rides on `index_delta`, so a root added, removed, ejected or plugged reaches every connected client instead of only whoever reloaded. The group UI becomes a plugin architecture: an application is a registry entry in `apps.js` plus its own files, with directories stored generically by `ops.set_app_directories` under whatever the app is called. A reference application, hidden behind `?dev=1`, is what makes that claim testable — adding it is what found the two places still naming apps by hand. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011pvMdvLBG92jyhvD5pD6us
Diffstat (limited to 'packages/meshbay-hub/tests/test_spa_imports.py')
-rw-r--r--packages/meshbay-hub/tests/test_spa_imports.py87
1 files changed, 87 insertions, 0 deletions
diff --git a/packages/meshbay-hub/tests/test_spa_imports.py b/packages/meshbay-hub/tests/test_spa_imports.py
new file mode 100644
index 0000000..230f33f
--- /dev/null
+++ b/packages/meshbay-hub/tests/test_spa_imports.py
@@ -0,0 +1,87 @@
+"""
+Every import in the SPA points at a file that exports what it names.
+
+The failure this catches has a distinctive shape: nothing errors at build time,
+because there is no build; the browser resolves the module graph at load, finds
+a binding that is not there, and the page renders blank or the component simply
+does not appear. `node --check` cannot see it — it parses one file at a time —
+and neither can the source-reading guards, which look inside a file rather than
+between two.
+
+Written after the settings-page split, which moved two shared components into a
+new module and rewired eight files to import them from there. That is exactly
+the change where a rename lands in one file and not the other.
+
+It is a static check, not a load: it says the name is exported, not that the
+value is what the caller expects. `test_spa_syntax` covers parsing;
+`test_hook_ordering` covers the ordering fault that also presents as a missing
+component.
+"""
+
+import re
+from pathlib import Path
+
+import pytest
+
+STATIC = Path(__file__).resolve().parents[1] / "src" / "meshbay_hub" / "static"
+
+pytestmark = pytest.mark.skipif(not STATIC.exists(),
+ reason="SPA sources unavailable")
+
+# `import { a, b as c } from './x.js';` / `import * as p from ...` / default.
+IMPORT = re.compile(
+ r"^import\s+(?:\{([^}]*)\}|(\*\s+as\s+\w+)|(\w+))\s+from\s+'([^']+)';", re.M)
+EXPORT_BLOCK = re.compile(r"^export\s+\{([^}]*)\};", re.M)
+EXPORT_DECL = re.compile(
+ r"^export\s+(?:default\s+)?(?:async\s+)?(?:function|const|class|let|var)\s+(\w+)",
+ re.M)
+
+
+def _exported(source: str) -> set[str]:
+ names = set(EXPORT_DECL.findall(source))
+ for block in EXPORT_BLOCK.findall(source):
+ for raw in block.split(","):
+ name = raw.strip().split(" as ")[-1].strip()
+ if name:
+ names.add(name)
+ return names
+
+
+def test_every_named_import_resolves():
+ problems: list[str] = []
+ for path in sorted(STATIC.glob("*.js")):
+ source = path.read_text(encoding="utf-8")
+ for names, star, default, spec in IMPORT.findall(source):
+ # vendor/ is third-party, bundled, and does not use a form this
+ # reads. Its exports are covered by the app failing to start.
+ if not spec.startswith("./") or "vendor/" in spec:
+ continue
+ target = (path.parent / spec[2:]).resolve()
+ if not target.exists():
+ problems.append(f"{path.name}: imports {spec} — no such file")
+ continue
+ if star or default or not names.strip():
+ continue
+ available = _exported(target.read_text(encoding="utf-8"))
+ for raw in names.split(","):
+ name = raw.strip().split(" as ")[0].strip()
+ if name and name not in available:
+ problems.append(
+ f"{path.name}: imports {{{name}}} from {spec}, "
+ f"which does not export it")
+
+ assert not problems, "unresolved imports:\n" + "\n".join(problems)
+
+
+def test_the_check_can_see_a_real_module():
+ """
+ Guard against the parser quietly matching nothing — a regex that stopped
+ finding imports would make the test above pass over an empty set, which
+ looks exactly like success.
+ """
+ source = (STATIC / "apps.js").read_text(encoding="utf-8")
+ found = IMPORT.findall(source)
+ assert len(found) >= 5, (
+ "the import pattern no longer matches apps.js — this test is then "
+ "checking nothing")
+ assert "configurableApps" in _exported(source)