fix: set the Windows node up at sign-in, and stop it for real

Found by the first Windows beta tester, then reproduced on a clean install.

After a service-mode install nothing set the node up for the account that
signed in: the boot task started a node that quit ("hub.username not set"),
and the sidebar showed Node / Create group only once the hub held a node key.
The only way to the wizard that provisions was the home page's welcome card,
which an account already in a group never sees. The way out was
`meshbay-node init` and the key pasted on the profile page -- which is also
what PACKAGING-GUIDE.md told people to do.

- main.js `node:ensure`, called by app.js at sign-in: provisions, starts and
  links the node this build ships (Windows, bundled node only). A node set up
  for another account, or an account linked to another node, is left alone.
  node:start waits for it, so the two never race.
- The sidebar shows the Node section when a node exists on this machine.
- The Node page's status is the node's: its control API and the process
  list, not the service task's state (a node started from a terminal ran
  while the page said Stopped). Stop says Stopped only once no
  meshbay-node.exe is left, and stays offered for a process that answers
  nothing.
- CLI stop kills the pid that answered when a graceful stop does not finish,
  and fails with the reason when a node process is still there.
- The daemon ends its process 3s after _shutdown(): Python's exit waited for a
  busy indexer thread, with the control API already closed. Armed by main()
  only, never by a daemon run inside a test.
- node.toml is read as utf-8-sig (PowerShell 5.1 writes a BOM), and a config
  that cannot be read is logged instead of dying silently in service mode.
- "Pair this browser" queues the code for the next group of this node to
  open instead of saying "Paired successfully"; no banner before a group.
- test_e2e_windows_app.py (opt-in, MESHBAY_WIN_E2E=1) drives the installed
  app against a throwaway hub: fresh account to linked node, Stop, Start,
  Restart, checked against the real processes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

1 files changed, 50 insertions, 7 deletions

diff --git a/packages/meshbay-node/src/meshbay_node/cli/lifecycle.py b/packages/meshbay-node/src/meshbay_node/cli/lifecycle.py
index 901c3d5..b461055 100644
--- a/packages/meshbay-node/src/meshbay_node/cli/lifecycle.py
+++ b/packages/meshbay-node/src/meshbay_node/cli/lifecycle.py
@@ -55,23 +55,36 @@ def _running_status(cfg) -> dict | None:
     return _await_daemon(cfg, since=0, timeout=0.1)
 
 
+class NodeStillRunning(RuntimeError):
+    pass
+
+
 def _stop_node(cfg) -> str:
     """Stop the node, whichever session it runs in: through its own control API
-    first, so it shuts down properly, then by force. Returns how it went."""
+    first, so it shuts down properly, then by force. Returns how it went, and
+    raises NodeStillRunning when a node process is still there at the end --
+    never "stopped" about a process nobody saw go."""
     import time
 
     from meshbay_node.platform import (
+        _pid_alive,
         autostart_end,
+        kill_pid,
+        node_pids,
         request_graceful_stop,
         service_end,
         service_state,
         service_status,
     )
+    answering = _running_status(cfg)
+    pid = answering.get("pid") if answering else None
     if request_graceful_stop(cfg.data_dir, cfg.node.ui_port):
         how = "stopped"
-    elif _running_status(cfg) is None:
+    elif answering is None and not node_pids():
         how = "not running"
     else:
+        # Asked and not gone: its control API closes first, so it may answer
+        # nothing while its process is still there.
         how = "stopped (forced)"
     if service_status()["installed"]:
         # Also leaves the task "Ready": a /run while it still reads "Running"
@@ -80,7 +93,17 @@ def _stop_node(cfg) -> str:
         deadline = time.monotonic() + 15
         while service_state().lower() == "running" and time.monotonic() < deadline:
             time.sleep(0.25)
+    if pid is not None and _pid_alive(int(pid)):
+        kill_pid(int(pid))    # the one that answered, by pid, wherever it came from
     autostart_end()   # a node in this session that would not stop
+    deadline = time.monotonic() + 5
+    while (left := node_pids()) and time.monotonic() < deadline:
+        time.sleep(0.25)
+    if left:
+        raise NodeStillRunning(
+            f"meshbay-node is still running (pid {', '.join(map(str, left))}) and could "
+            "not be stopped from here -- it was probably started from an "
+            "administrator prompt. Stop it there, or end it in Task Manager.")
     return how
 
 
@@ -94,7 +117,12 @@ def _start_and_confirm(args, action: str) -> None:
 
     cfg = load_config(args.config or DEFAULT_CONFIG_PATH)
     if action == "restart":
-        _stop_node(cfg)
+        try:
+            _stop_node(cfg)
+        except NodeStillRunning as e:
+            # Starting another would find the port taken and quit at once.
+            print(f"Could not restart the node: {e}")
+            sys.exit(1)
     else:
         already = _running_status(cfg)
         if already is not None:
@@ -122,6 +150,21 @@ def _start_and_confirm(args, action: str) -> None:
               "its files were not replaced, or another copy was started.")
 
 
+def _print_stop(args) -> None:
+    try:
+        print(_stop_node(load_config(args.config or DEFAULT_CONFIG_PATH)))
+    except NodeStillRunning as e:
+        print(e)
+        sys.exit(1)
+
+
+def _stop_node_or_warn(args) -> None:
+    try:
+        _stop_node(load_config(args.config or DEFAULT_CONFIG_PATH))
+    except NodeStillRunning as e:
+        print(f"warning: {e}")
+
+
 def restart_daemon(args) -> None:
     if sys.platform == "win32":
         _start_and_confirm(args, "restart")
@@ -161,7 +204,7 @@ def autostart(args) -> None:
     elif sub == "start":
         _start_and_confirm(args, "start")
     elif sub == "stop":
-        print(_stop_node(load_config(args.config or DEFAULT_CONFIG_PATH)))
+        _print_stop(args)
     elif sub == "status":
         st = _plat.autostart_status()
         if st["installed"]:
@@ -186,7 +229,7 @@ def service(args) -> None:
     if sub == "install":
         # A node already running in this session holds the control API's port:
         # the service's own would exit at once, leaving the old one in charge.
-        _stop_node(load_config(args.config or DEFAULT_CONFIG_PATH))
+        _stop_node_or_warn(args)
         try:
             _plat.service_install()
         except RuntimeError as e:
@@ -201,7 +244,7 @@ def service(args) -> None:
     elif sub == "remove":
         # Deleting a task does not end its running instance: stop the node
         # first, or it runs on in session 0 with nothing left to stop it.
-        _stop_node(load_config(args.config or DEFAULT_CONFIG_PATH))
+        _stop_node_or_warn(args)
         _plat.service_remove()
         print(f"Removed the {_plat.TASK_NAME!r} scheduled task.")
     elif sub == "start":
@@ -211,7 +254,7 @@ def service(args) -> None:
             sys.exit(1)
         _start_and_confirm(args, "start")
     elif sub == "stop":
-        print(_stop_node(load_config(args.config or DEFAULT_CONFIG_PATH)))
+        _print_stop(args)
     elif sub == "status":
         st = _plat.service_status()
         if st["installed"]: