fix(node): node.toml's transfer pools reach the transport

The daemon built the defaults dict for `Roster.node_settings` by hand and
left out `max_concurrent_downloads` and `max_concurrent_uploads`. Absent
from the dict, both resolved to None, were assigned back onto the config,
and the transport skipped them — so node.toml was parsed, validated, and
then replaced by `transfers.py`'s own 8. Invisible to anyone who left the
value at 8, which is the value the template suggests.

There were three copies of that dict and they all disagreed: node_status'
was missing those two and `max_upload_gb` besides. One builder now,
`config.node_settings_defaults`, and the resolver's key list is a class
attribute the tests hold it to, along with the writer's.

1429 passed against a baseline of 1423; the two new behavioural tests fail
with the builder reverted.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1 files changed, 30 insertions, 37 deletions

diff --git a/packages/meshbay-node/src/meshbay_node/ops.py b/packages/meshbay-node/src/meshbay_node/ops.py
index 9f0e6d1..b95ee2b 100644
--- a/packages/meshbay-node/src/meshbay_node/ops.py
+++ b/packages/meshbay-node/src/meshbay_node/ops.py
@@ -40,6 +40,7 @@ from meshbay_common.crypto import (
 from meshbay_node.config import DEFAULT_CONFIG_PATH
 from meshbay_common.join import ROLE_MEMBER, ROLE_OPERATOR
 from meshbay_node.roots import RootError, RootSet, off_disk
+from meshbay_node.roster import Roster
 
 log = logging.getLogger(__name__)
 
@@ -623,17 +624,11 @@ async def list_groups(state: dict) -> dict:
         members = await roster.list_members()
         has_operator = any(m["role"] == "operator" and m["status"] == "active"
                           for m in members)
-    from meshbay_node.config import DEFAULT_STUN_SERVERS
-    nd = config.node if config else None
-    defaults = {
-        "invite_ttl_hours": nd.invite_ttl_hours if nd else 168,
-        "pair_ttl_hours": nd.pair_ttl_hours if nd else 24,
-        "device_request_ttl_minutes": nd.device_request_ttl_minutes if nd else 60,
-        "max_concurrent_streams": nd.max_concurrent_streams if nd else 8,
-        "transcode_incompatible_video": nd.transcode_incompatible_video if nd else True,
-        "stun_servers": nd.stun_servers if nd and nd.stun_servers else list(DEFAULT_STUN_SERVERS),
-        "ice_interfaces": nd.ice_interfaces if nd else [],
-    }
+    from meshbay_node.config import node_settings_defaults
+    # No config (a test, an unconfigured node) falls back to NodeConfig()'s own
+    # values rather than to numbers repeated here, which is the copy this used
+    # to be: it was missing three settings and reported them as null.
+    defaults = node_settings_defaults(config.node if config else None)
     if roster:
         settings = await roster.node_settings(defaults)
     else:
@@ -1288,24 +1283,33 @@ async def clear_denylist(state: dict, *, subject: str = "") -> dict:
 
 # ── Node settings ────────────────────────────────────────────────────────────
 
+# What `set_node_settings` accepts, and how each value is validated. A module
+# constant so a test can hold its key set against `Roster.node_setting_keys()`:
+# this is the third list of the same settings, and the first two had already
+# drifted apart once — the reader's defaults covered fewer settings than the
+# resolver answered for, which is how node.toml's transfer pools came to be
+# parsed and then ignored. The kinds here are the *writer's* validation and
+# deliberately not the resolver's coercions.
+NODE_SETTING_WRITERS: dict[str, tuple[str, str]] = {
+    "invite_ttl_hours": ("int", Roster.SETTING_INVITE_TTL),
+    "pair_ttl_hours": ("int", Roster.SETTING_PAIR_TTL),
+    "device_request_ttl_minutes": ("int", Roster.SETTING_DEVICE_TTL),
+    "max_concurrent_streams": ("int", Roster.SETTING_MAX_STREAMS),
+    "max_concurrent_downloads": ("int", Roster.SETTING_MAX_DOWNLOADS),
+    "max_concurrent_uploads": ("int", Roster.SETTING_MAX_UPLOADS),
+    "max_upload_gb": ("size", Roster.SETTING_MAX_UPLOAD_GB),
+    "transcode_incompatible_video": ("bool", Roster.SETTING_TRANSCODE),
+    "stun_servers": ("stun_list", Roster.SETTING_STUN_SERVERS),
+    "ice_interfaces": ("list", Roster.SETTING_ICE_INTERFACES),
+}
+
+
 async def get_node_settings(state: dict) -> dict:
     """Return current effective node settings."""
-    from meshbay_node.config import DEFAULT_STUN_SERVERS
+    from meshbay_node.config import node_settings_defaults
     roster = _roster(state)
     config = _config(state)
-    nd = config.node
-    defaults = {
-        "invite_ttl_hours": nd.invite_ttl_hours,
-        "pair_ttl_hours": nd.pair_ttl_hours,
-        "device_request_ttl_minutes": nd.device_request_ttl_minutes,
-        "max_concurrent_streams": nd.max_concurrent_streams,
-        "max_concurrent_downloads": nd.max_concurrent_downloads,
-        "max_concurrent_uploads": nd.max_concurrent_uploads,
-        "max_upload_gb": nd.max_upload_gb,
-        "transcode_incompatible_video": nd.transcode_incompatible_video,
-        "stun_servers": nd.stun_servers if nd.stun_servers else list(DEFAULT_STUN_SERVERS),
-        "ice_interfaces": nd.ice_interfaces,
-    }
+    defaults = node_settings_defaults(config.node)
     if roster:
         return await roster.node_settings(defaults)
     return defaults
@@ -1317,18 +1321,7 @@ async def set_node_settings(state: dict, settings: dict) -> dict:
     nd = config.node
     conf_path = Path(state.get("config_path") or DEFAULT_CONFIG_PATH)
 
-    allowed_keys = {
-        "invite_ttl_hours": ("int", roster.SETTING_INVITE_TTL),
-        "pair_ttl_hours": ("int", roster.SETTING_PAIR_TTL),
-        "device_request_ttl_minutes": ("int", roster.SETTING_DEVICE_TTL),
-        "max_concurrent_streams": ("int", roster.SETTING_MAX_STREAMS),
-        "max_concurrent_downloads": ("int", roster.SETTING_MAX_DOWNLOADS),
-        "max_concurrent_uploads": ("int", roster.SETTING_MAX_UPLOADS),
-        "max_upload_gb": ("size", roster.SETTING_MAX_UPLOAD_GB),
-        "transcode_incompatible_video": ("bool", roster.SETTING_TRANSCODE),
-        "stun_servers": ("stun_list", roster.SETTING_STUN_SERVERS),
-        "ice_interfaces": ("list", roster.SETTING_ICE_INTERFACES),
-    }
+    allowed_keys = NODE_SETTING_WRITERS
 
     set_by = state.get("node_user_id", "")
     updated = {}