Merge branch 'fix/large-download-paths'

Concurrent-transfer limits, with the queue, the pause and the flag day.

A node now caps how many transfers it runs at once (8 downloads, 8 uploads,
node-wide) and how many one member may run in one group (2 by default,
operator-signed). Beyond that the node answers "queued" and the client waits its
turn, visibly, in the transfers panel — and a slot that frees starts whatever is
next, skipping past a member who is at their own cap rather than letting them
stall everyone behind them.

Browsing is never subject to a slot: not the poster grid, not the covers, not
opening a photo to look at it. That is structural — a transfer is what the
transfers widget shows — and the exemption is bounded rather than open, at two
files in flight per session, because an exemption with no bound is a leaseless
branch under another name.

Transfers can be cancelled, and now paused and resumed. A paused one holds
nothing: its slot goes back at once and resuming rejoins the queue at the tail.
Uploads survive the connection that started them and resume where the node
stopped, asked for inside the seal rather than on a clear message. What they
leave behind when they are abandoned is reaped, which closes a disk leak that
predates this work.

MNP 3.0 makes the lease compulsory and refuses 2.x at the handshake, with the
desktop client checking `client.minimum` before connecting so an un-updated one
says "update" instead of failing every connection in a protocol vocabulary.

Fourteen defects were found on the way, eight of them by a person clicking
Download and pasting a console — none of which 2075 tests could reach. Section
12 of ~/next/improve-downloads.md is that report, including the three this work
introduced itself and the one that turned out to be caused by an instruction to
hard-reload after each deployment.

Node suite 1209 passed, hub suite 866 passed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HCGdheDLxGReuKHga3BtST

1 files changed, 10 insertions, 0 deletions

diff --git a/packages/meshbay-node/tests/test_platform.py b/packages/meshbay-node/tests/test_platform.py
index 92e74df..3fb27f3 100644
--- a/packages/meshbay-node/tests/test_platform.py
+++ b/packages/meshbay-node/tests/test_platform.py
@@ -71,6 +71,10 @@ def test_check_media_tools_raises_when_ffmpeg_is_missing(monkeypatch):
 
 
 def test_check_media_tools_stores_the_resolved_paths(monkeypatch):
+    # This call writes two module globals, and what undoes them is the autouse
+    # `_restore_media_tool_paths` fixture in conftest.py -- see it for what went
+    # wrong when nothing did. Deliberately not repeated here: one mechanism, one
+    # explanation, or the two drift.
     monkeypatch.setattr(plat.shutil, "which",
                         lambda n: f"/opt/bin/{n}.exe")
     plat.check_media_tools("ffmpeg", "ffprobe")
@@ -365,6 +369,9 @@ def test_service_install_uses_s4u_not_a_stored_password(monkeypatch):
     credential validation, and omitting /rp registers "Interactive only",
     which never runs at boot or on demand. See platform.py's service mode
     comment for the full story."""
+    # Service mode is Windows-only and refuses outright anywhere else;
+    # every other test in this file says so, these two never did.
+    monkeypatch.setattr(sys, "platform", "win32")
     monkeypatch.setattr(plat, "_current_user", lambda: "DOMAIN\\user")
     calls = []
     monkeypatch.setattr(
@@ -388,6 +395,9 @@ def test_service_install_tolerates_no_startup_launcher_present(win_startup, monk
 
 
 def test_service_install_raises_with_powershells_error_message(monkeypatch):
+    # Service mode is Windows-only and refuses outright anywhere else;
+    # every other test in this file says so, these two never did.
+    monkeypatch.setattr(sys, "platform", "win32")
     monkeypatch.setattr(plat, "_current_user", lambda: "DOMAIN\\user")
     monkeypatch.setattr(
         plat.subprocess, "run",