aboutsummaryrefslogtreecommitdiffstats
path: root/packages/meshbay-node/tests/test_replug_restores_enrichment.py
diff options
context:
space:
mode:
authorChristophe Besson <cbesson@gmail.com>2026-09-08 14:04:47 +0200
committerChristophe Besson <cbesson@gmail.com>2026-09-08 14:04:47 +0200
commit038066c43caa8ee76dd1e04761234271e4e67ecd (patch)
tree502fb9b090197dc75135b968efcd715b386a8713 /packages/meshbay-node/tests/test_replug_restores_enrichment.py
parent28f1b5686c7ab200aeda6782f5f6e829c24759dd (diff)
downloadmeshbay-038066c43caa8ee76dd1e04761234271e4e67ecd.tar.gz
fix(node): make max_concurrent_streams take effect without a restart
`ops.set_node_settings` hot-swapped the stream pool by assigning `webrtc._stream_sem`. That attribute has never existed on WebRTCTransport — the pool is `ctx["_transcode_sem"]` — so `hasattr(webrtc, '_stream_sem')` was always False and the branch never ran. The setting was accepted, written to roster.db and node.toml, and applied only on the next restart, which is exactly what draft-v6 §2.11 says it does not need. An operator lowering the cap on a struggling machine, or raising it after "Server busy", saw nothing happen and had no way to find out why. `WebRTCTransport.set_capacity()` is the one implementation, on the object that owns the state, so the download and upload caps the transfer-slots plan adds next do not each grow their own copy of the mistake. Resizing has semantics worth stating: the new cap governs new streams and never interrupts one that is running, because a slot is held for the length of a film and lowering a number must not take somebody's film away. The replacement pool is built with the permits that remain (`new - in_flight`, floored at zero) — a full set would briefly allow more concurrent viewers than either the old cap or the new one. That needs a count of slots in use, so `_stream_video` now maintains one instead of the code reading the semaphore's private `_value`: a number this code keeps itself survives the semaphore object being replaced underneath it, and the same counter makes the "N of M in use" log lines mean something. test_stream_capacity.py drives the real transport and the real `_stream_video`; `test_ops_calls_the_real_mechanism` fails if the dead attribute comes back. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HCGdheDLxGReuKHga3BtST
Diffstat (limited to 'packages/meshbay-node/tests/test_replug_restores_enrichment.py')
0 files changed, 0 insertions, 0 deletions