aboutsummaryrefslogtreecommitdiffstats
path: root/packages/meshbay-node/tests/test_root_ops_reach_the_live_set.py
diff options
context:
space:
mode:
authorChristophe Besson <cbesson@gmail.com>2026-09-27 22:21:26 +0200
committerChristophe Besson <cbesson@gmail.com>2026-09-27 22:21:26 +0200
commita45e77df1b0024707914a446aa89d33baa223787 (patch)
tree969a4976c91d7aaa27b11ba212f99d69e2ccce0f /packages/meshbay-node/tests/test_root_ops_reach_the_live_set.py
parentc7899e2218af26f3bab6a157c70acf5eb7871da6 (diff)
downloadmeshbay-a45e77df1b0024707914a446aa89d33baa223787.tar.gz
test: make both suites pass on Windows
Most of these failed on Windows for reasons that had nothing to do with the code under test, which is how real Windows defects hid among them: - Read and write files as UTF-8, and talk to Node in UTF-8. read_text(), write_text() and subprocess text=True use the locale codepage, cp1252 on Windows: "é", "—" and "→" arrived as "?" or crashed, some sixty tests. Calls to PowerShell and schtasks are left alone -- they answer in the console codepage. - Import ESM harness modules by file URL (as_uri): a raw "C:\..." path is not a module specifier. - test_cli_golden: mask the tmp path in its JSON-escaped form, spell it the POSIX way, record on Linux, mask the protocol version (the recording had failed everywhere since the MNP 4.0 bump) and argparse's version-dependent quoting; point USERPROFILE at the tmp home, or `member invite` and `operator pair` wrote their codes into the developer's profile. - test_disk_io_off_loop: expect what a free loop can reach on the platform's timer, 15.6 ms on Windows, not an assumed 5 ms. - test_root_paths_are_operator_only: expect the OS's spelling of the path. - test_audio_meta_cache: find ffprobe with shutil.which. Node suite on Windows: 1489 passed, none failed. Hub suite: 3 failures left, all older than this change (two SQLite concurrency tests, one transfer resume). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Diffstat (limited to 'packages/meshbay-node/tests/test_root_ops_reach_the_live_set.py')
-rw-r--r--packages/meshbay-node/tests/test_root_ops_reach_the_live_set.py12
1 files changed, 6 insertions, 6 deletions
diff --git a/packages/meshbay-node/tests/test_root_ops_reach_the_live_set.py b/packages/meshbay-node/tests/test_root_ops_reach_the_live_set.py
index e90fdfe..b2b3650 100644
--- a/packages/meshbay-node/tests/test_root_ops_reach_the_live_set.py
+++ b/packages/meshbay-node/tests/test_root_ops_reach_the_live_set.py
@@ -58,7 +58,7 @@ async def _state(tmp_path: Path) -> tuple[dict, Roster]:
f' [[groups.roots]]\n path = "{(tmp_path / "one").as_posix()}"\n'
f' name = "one"\n\n'
f' [[groups.roots]]\n path = "{(tmp_path / "two").as_posix()}"\n'
- f' name = "two"\n')
+ f' name = "two"\n', encoding="utf-8")
live = RootSet.build([asdict(r) for r in cfg.roots])
index = GroupIndex(group_id=GROUP, sk_node=Ed25519PrivateKey.generate())
@@ -101,7 +101,7 @@ async def test_adding_a_root_reaches_node_toml_and_the_ack(tmp_path):
assert [r["name"] for r in result["roots"]] == ["one", "two", "uploads"]
assert [r.name for r in state["config"].groups[0].roots] == [
"one", "two", "uploads"]
- assert "uploads" in Path(state["config_path"]).read_text()
+ assert "uploads" in Path(state["config_path"]).read_text(encoding="utf-8")
finally:
await roster.close()
@@ -111,7 +111,7 @@ async def test_removing_a_root_reaches_node_toml_and_the_ack(tmp_path):
try:
result = await ops.remove_root(state, GROUP, "two")
assert [r["name"] for r in result["roots"]] == ["one"]
- assert Path(state["config_path"]).read_text().count(
+ assert Path(state["config_path"]).read_text(encoding="utf-8").count(
"[[groups.roots]]") == 1
finally:
await roster.close()
@@ -229,7 +229,7 @@ async def test_adding_the_same_directory_twice_is_still_refused(tmp_path):
await ops.add_root(state, GROUP, str(tmp_path / "uploads"))
assert len(state["config"].groups[0].roots) == 3, (
"the refused add left something behind")
- assert Path(state["config_path"]).read_text().count(
+ assert Path(state["config_path"]).read_text(encoding="utf-8").count(
"[[groups.roots]]") == 3
finally:
await roster.close()
@@ -283,12 +283,12 @@ async def test_the_file_on_disk_and_the_config_in_memory_agree(tmp_path):
await ops.remove_root(state, GROUP, "one")
import tomllib
- on_disk = tomllib.loads(Path(state["config_path"]).read_text())
+ on_disk = tomllib.loads(Path(state["config_path"]).read_text(encoding="utf-8"))
disk_paths = [str(r["path"]) for r in on_disk["groups"][0]["roots"]]
memory_paths = [Path(r.path).as_posix()
for r in state["config"].groups[0].roots]
assert disk_paths == memory_paths
- assert Path(state["config_path"]).read_text().count(
+ assert Path(state["config_path"]).read_text(encoding="utf-8").count(
"[[groups.roots]]") == 2
finally:
await roster.close()