refactor: drop the unread transfer_limits field from the handshake ack

The interface reads a member's cap from transfer_state and never read the
copy on the ack. The transfer probe reads it from transfer_state too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

1 files changed, 17 insertions, 12 deletions

diff --git a/packages/meshbay-node/tests/transfer_probe.py b/packages/meshbay-node/tests/transfer_probe.py
index 7aa4902..6666960 100755
--- a/packages/meshbay-node/tests/transfer_probe.py
+++ b/packages/meshbay-node/tests/transfer_probe.py
@@ -274,7 +274,14 @@ async def operator_checks(client, ack, group, node_id) -> int:
     import re as _re
 
     failures = 0
-    member_cap = int((ack.get("transfer_limits") or {}).get("download") or 0)
+    # This member's own cap, as the node states it on every `transfer_state`.
+    probe_tr, probe_state = await _open_transfer(client)
+    member_cap = int(probe_state.get("cap") or 0)
+    client.send({"type": "transfer_close", "v": "0.1", "tr": probe_tr, "reason": "done"})
+    while True:   # closed before anything below counts what is in use
+        reply = await client.recv_type("transfer_state", timeout=15)
+        if reply.get("tr") == probe_tr and reply.get("state") == "closed":
+            break
 
     # The queue has to be held by the *node* cap, not by this member's own.
     #
@@ -446,16 +453,6 @@ async def probe(args) -> int:
 
         ack = await alice.connect(http, group["id"], node_id)
 
-        limits = ack.get("transfer_limits")
-        if limits is None:
-            print("This node does not hand out transfer slots — it predates "
-                  "them, or the handshake ack lost the field. Nothing below "
-                  "can be measured.")
-            await alice.close()
-            return 1
-        cap = int(limits.get("download") or 0)
-        print(f"node reports this member may run {cap} download(s) at once\n")
-
         if args.operator:
             return await operator_checks(alice, ack, group, node_id)
 
@@ -472,9 +469,17 @@ async def probe(args) -> int:
         # held. So the first reply is read for what the node says is already
         # in use, and the run stops rather than measuring against a moving
         # floor.
-        want = args.want or (cap + 2)
         opened = [await _open_transfer(alice)]
         first = opened[0][1]
+        # This member's cap, as the node states it on every `transfer_state`.
+        cap = int(first.get("cap") or 0)
+        if not cap:
+            print("This node does not state a transfer cap — nothing below can "
+                  "be measured.")
+            await alice.close()
+            return 1
+        print(f"node reports this member may run {cap} download(s) at once\n")
+        want = args.want or (cap + 2)
         if first.get("state") != "granted" or first.get("used", 1) != 1:
             print(f"this node is not idle: it reports {first.get('used')} of "
                   f"{first.get('cap')} slots already used by this member, and "