diff options
| author | Christophe Besson <cbesson@gmail.com> | 2026-09-19 01:15:53 +0200 |
|---|---|---|
| committer | Christophe Besson <cbesson@gmail.com> | 2026-09-19 01:15:53 +0200 |
| commit | cc0820de8d8c33560c44bd6a0864de30e33a0109 (patch) | |
| tree | 9e55601ea84a94fc5f79e2a3bf0fd13be1c0fc17 /packaging/win/electron-builder.msix.yml | |
| parent | 345a59fc128e5e4f253c277c8cee69a2b1062a4f (diff) | |
| download | meshbay-cc0820de8d8c33560c44bd6a0864de30e33a0109.tar.gz | |
docs: drop the references to design notes that live outside the repo
Seventeen comments across the Windows packaging targets pointed at
C:\Users\admin\devel\light-client.md and msix-installer.md -- absolute
paths on one developer's machine, unreadable to anyone else who clones
this repository and unverifiable by any test here.
The surrounding prose already carried the substance in every case, so
these are removals, not rewrites, with two exceptions where the pointer
was doing real work:
electron-builder.msix.yml's header told the reader to go read §4 and §8
first. It now states the fact directly (an AppX/MSIX install never
elevates, by design, so the package carries none of installer.nsh's
elevation logic) and says the open items are called out at each
declaration below -- which they already were, at `capabilities` and
`customExtensionsPath`.
The two "msix-installer.md §8" citations become "an open item" / "the
other open item", beside the description of the item that was already
there.
Paragraphs the removals left ragged are re-wrapped.
Verified: node suite 1403 pass / 4 skip (71 of them test_packaging_win.py),
both electron-builder configs still parse as YAML, node --check on main.js.
The .ps1 edits are inside <# #> comment headers plus one deleted Write-Host
in a block that keeps two others; no pwsh on this machine to parse them.
Not touched, and much larger: ~230 comments elsewhere in the codebase cite
per-feature design notes (musicbay.md, mediacenter.md, auth-confirm.md and
twenty more) that were merged into docs/MESHBAY_DESIGN.md.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Diffstat (limited to 'packaging/win/electron-builder.msix.yml')
| -rw-r--r-- | packaging/win/electron-builder.msix.yml | 20 |
1 files changed, 9 insertions, 11 deletions
diff --git a/packaging/win/electron-builder.msix.yml b/packaging/win/electron-builder.msix.yml index 5e45598..5460267 100644 --- a/packaging/win/electron-builder.msix.yml +++ b/packaging/win/electron-builder.msix.yml @@ -1,9 +1,8 @@ # Standalone electron-builder config for the "MSIX" Windows target: same # feature set as Full (bundled node + ffmpeg), packaged for Microsoft Store -# submission instead of NSIS. See C:\Users\admin\devel\msix-installer.md for -# the plan this implements -- read that first, especially §4 (why the -# installer can carry none of installer.nsh's elevation logic: an AppX/MSIX -# install never elevates, by design) and §8 (what is still unverified here). +# submission instead of NSIS. The package carries none of installer.nsh's +# elevation logic: an AppX/MSIX install never elevates, by design. What is +# still unverified here is called out at each declaration below. # # Deliberately NOT layered onto package.json's `build` field, same reasoning # as electron-builder.light.yml: --config reads ONLY this file, so nothing @@ -22,8 +21,8 @@ # windowsSignToolManager.js (computePublisherName), an AppX target built # with no certificate configured is logged as "Windows Store only build" and # left unsigned, with `publisher` written into the manifest as-is. Microsoft -# signs the package itself at publish time (msix-installer.md §3) -- signing -# it here first would be pointless work, not extra safety. +# signs the package itself at publish time -- signing it here first would be +# pointless work, not extra safety. appId: org.meshbay.client productName: MeshBay @@ -102,9 +101,9 @@ appx: # firewall.ps1's own rules, which are `-Profile Any` (private AND public # network). Whether Windows Firewall actually auto-exempts a full-trust # packaged app on the strength of these declarations -- eliminating the - # elevation firewall.ps1 exists for entirely -- is msix-installer.md §8's - # #1 open item: verify live before relying on it, the declaration alone - # only proves the manifest is well-formed. + # elevation firewall.ps1 exists for entirely -- is an open item: verify + # live before relying on it, the declaration alone only proves the + # manifest is well-formed. capabilities: - internetClientServer - privateNetworkClientServer @@ -116,7 +115,6 @@ appx: # switch to point it at a different bundled exe). build/appx-extensions.xml # declares that extension by hand for exactly this reason. Whether # Windows actually launches a *non-primary* bundled exe through this - # mechanism is the other open item in msix-installer.md §8 -- untested - # until sideloaded. + # mechanism is the other open item -- untested until sideloaded. customExtensionsPath: build/appx-extensions.xml showNameOnTiles: false |