fix: Windows installer and desktop app start and stop the node one way

A 0.16 upgrade in service mode left the previous node running: setup's
unelevated taskkill cannot reach session 0, and it ran in customInstall, which
electron-builder inserts after the files are copied. The locked exe was not
replaced, and the new app talked to the old node ("started but could not link",
"No operator paired").

Installer (build/installer.nsh, build/stop-node.ps1):
- customCheckAppRunning, which runs before uninstallOldVersion and extraction,
  stops the node with an embedded stop-node.ps1: control API, then schtasks
  /end, then Stop-Process, and refuses to half-upgrade if one survives.
- An upgrade keeps the mode it finds (task, launcher, previous install),
  restores the sign-in launcher the old uninstaller deletes, and restarts the
  node the way that mode runs it. A silent upgrade of an "at sign-in" install
  used to end with no autostart and no node.
- The uninstaller removes the task and firewall rules only on a real
  uninstall, not on an update.

Desktop app (src/main.js):
- Start, Stop, Restart and node:start go through the CLI's lifecycle verbs
  instead of a second implementation; a child spawned by Electron also held
  Electron's sockets after the app quit.
- "Only while MeshBay is open" is a real mode: the app starts a provisioned
  node at launch and stops the one it started when it quits.
- Switching modes stops the node first -- deleting a task does not end its
  instance, and a new service found the port taken -- keeps the firewall
  rules every mode needs, and starts the node again. A declined or unanswered
  UAC prompt restores the node instead of leaving it stopped, and says that
  nothing changed.
- waiting_for_hub counts as a node that is up; linking waits for a node that
  answers, with a longer deadline, and reports a version mismatch.

Packaging (packaging/win):
- The service task gets no 72-hour limit, runs on battery and ignores a second
  start; service.ps1 status reports a stale registration so setup re-registers
  it; remove ends the running instance before deleting the task.
- build-node-runtime.ps1 starts the frozen daemon in a throwaway profile
  (smoke-node-runtime.ps1) instead of only asking for --help.

The mode that was "Off (start manually)" is labelled "Only while MeshBay is
open" in all ten catalogues.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

1 files changed, 26 insertions, 1 deletions

diff --git a/packaging/win/service.ps1 b/packaging/win/service.ps1
index 1f84a29..a46bb19 100644
--- a/packaging/win/service.ps1
+++ b/packaging/win/service.ps1
@@ -78,15 +78,28 @@ switch ($Action) {
         $taskAction = New-ScheduledTaskAction -Execute $node
         $bootTrigger = New-ScheduledTaskTrigger -AtStartup
         $taskPrincipal = New-ScheduledTaskPrincipal -UserId $user -LogonType S4U -RunLevel Limited
+        # Task Scheduler's defaults end a task after 72 hours, never start it on
+        # battery and stop it when the cable comes out. Kept identical to
+        # meshbay_node.platform.SERVICE_TASK_SETTINGS.
+        $taskSettings = New-ScheduledTaskSettingsSet -ExecutionTimeLimit ([TimeSpan]::Zero) `
+            -AllowStartIfOnBatteries -DontStopIfGoingOnBatteries `
+            -MultipleInstances IgnoreNew -StartWhenAvailable
         Register-ScheduledTask -TaskName $TASK_NAME -Action $taskAction -Trigger $bootTrigger `
-            -Principal $taskPrincipal -Force -ErrorAction Stop | Out-Null
+            -Principal $taskPrincipal -Settings $taskSettings -Force -ErrorAction Stop | Out-Null
         Write-Host "service: installed ($user, runs at boot)"
     }
     "remove" {
+        # Deleting a task does not end its running instance.
+        & schtasks /end /tn $TASK_NAME 2>$null | Out-Null
         & schtasks /delete /tn $TASK_NAME /f 2>$null | Out-Null
         Write-Host "service: removed"
     }
     "status" {
+        # Exit 0: installed and current. 1: not installed. 2: installed but
+        # stale -- it runs another executable than this install's (an older
+        # install dir, a dev venv), or it still has the 72-hour / battery
+        # defaults. The installer re-registers a stale task; reading all of this
+        # needs no admin.
         $out = & schtasks /query /tn $TASK_NAME /fo list 2>$null
         if ($LASTEXITCODE -ne 0) {
             Write-Output "NOT_INSTALLED"
@@ -94,6 +107,18 @@ switch ($Action) {
         }
         $line = $out | Select-String "^Status:"
         $state = if ($line) { ($line -replace "^Status:\s*", "").Trim() } else { "unknown" }
+        $task = Get-ScheduledTask -TaskName $TASK_NAME -ErrorAction SilentlyContinue
+        $stale = $true
+        if ($task) {
+            $exe = ([string]$task.Actions[0].Execute).Trim('"')
+            $s = $task.Settings
+            $stale = ($exe -ne $node) -or ($s.ExecutionTimeLimit -ne "PT0S") `
+                -or $s.DisallowStartIfOnBatteries -or $s.StopIfGoingOnBatteries
+        }
+        if ($stale) {
+            Write-Output "INSTALLED_STALE:$state"
+            exit 2
+        }
         Write-Output "INSTALLED:$state"
         exit 0
     }