diff options
Diffstat (limited to 'docs/transfers-v1.md')
| -rw-r--r-- | docs/transfers-v1.md | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/docs/transfers-v1.md b/docs/transfers-v1.md index 47e82a6..e9caadb 100644 --- a/docs/transfers-v1.md +++ b/docs/transfers-v1.md @@ -73,7 +73,7 @@ this repo about slots — `_replace_stream`, `shutdown_tasks()`, `_spawn()` and the garbage-collected task, `await proc.wait()` after `kill()` — is a lesson about *not losing a slot*. That history is why §5 exists. -**One bug found while reading, in scope for this work.** `ops.py:1362-1365` +**One bug found while reading, in scope for this work.** `set_node_settings` (`ops/settings.py`) hot-swaps the stream cap by assigning `webrtc._stream_sem` — an attribute that does not exist. The real semaphore is `ctx["_transcode_sem"]` (`_transcode_semaphore`, `webrtc/apps/streaming.py`), and `hasattr(webrtc, '_stream_sem')` is always @@ -585,8 +585,8 @@ Two new `[node]` keys, `max_concurrent_downloads` and - `roster.py`: `SETTING_MAX_DOWNLOADS` / `SETTING_MAX_UPLOADS`, added to `node_settings()` (`roster.py:943`); -- `ops.py`: entries in `get_node_settings` / `set_node_settings` - (`ops.py:1290`, `ops.py:1309`), written to `roster.db` **and** `node.toml`; +- `ops/settings.py`: entries in `get_node_settings` / `set_node_settings`, + written to `roster.db` **and** `node.toml`; - **hot-swap through one helper.** `ops.set_node_settings` currently pokes `webrtc._stream_sem`, which does not exist (§1). Replace all three with `webrtc.set_capacity(streams=…, downloads=…, uploads=…)` on @@ -805,7 +805,7 @@ test. - `test_upload_resume.py` — reconnect mid-upload resumes at `next_index`; orphan `.part` reaped; `stored_name` preserved. - `test_node_settings.py` extension — `set_capacity` actually resizes a live - pool (the test `ops.py:1362` never had). + pool (the test `set_node_settings` never had). **Hub / SPA (`packages/meshbay-hub/tests/`)** |