diff options
Diffstat (limited to 'packages/meshbay-node/tests/test_packaging_win.py')
| -rw-r--r-- | packages/meshbay-node/tests/test_packaging_win.py | 50 |
1 files changed, 49 insertions, 1 deletions
diff --git a/packages/meshbay-node/tests/test_packaging_win.py b/packages/meshbay-node/tests/test_packaging_win.py index ed8104f..6ee4891 100644 --- a/packages/meshbay-node/tests/test_packaging_win.py +++ b/packages/meshbay-node/tests/test_packaging_win.py @@ -285,7 +285,7 @@ def test_the_installer_asks_the_node_to_stop_before_forcing_it(): src = STOP_NODE_PS1.read_text(encoding="utf-8") i_api = src.index("/api/shutdown") i_task = src.index("schtasks /end /tn \"MeshBay Node\"") - i_kill = src.index("Stop-Process -Force") + i_kill = src.index("Stop-Process -Force", src.index("Get-Process -Name meshbay-node ")) assert i_api < i_task < i_kill, ( "graceful through the control API, then Task Scheduler, then taskkill") assert "ui_port" in src and r"data\ui-token" in src @@ -426,6 +426,54 @@ def _dummy_node(tmp_path, name): @pytest.mark.skipif(sys.platform != "win32", reason="runs the installer's PowerShell for real") +def test_setup_ends_the_command_line_client_of_this_install_only(tmp_path): + """A `meshbay-cli chat --follow` left open holds node-runtime's DLLs, and the + previous version's uninstaller then failed the update, silent ones too + ("Failed to uninstall old application files", seen live). Setup ends a + client run from its own install, and no other copy of the same name.""" + import shutil + import subprocess + + name = "mbclistoptest" + install = tmp_path / "MeshBay" + runtime = install / "resources" / "node-runtime" + runtime.mkdir(parents=True) + elsewhere = tmp_path / "elsewhere" + elsewhere.mkdir() + procs = [] + for where in (runtime, elsewhere): + exe = where / f"{name}.exe" + shutil.copy(r"C:\Windows\System32\PING.EXE", exe) + procs.append(subprocess.Popen([str(exe), "-n", "300", "127.0.0.1"], + stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)) + ours, other = procs + script = (STOP_NODE_PS1.read_text(encoding="utf-8") + .replace('"MeshBay Node"', '"MeshBay Node stop-test"') + .replace("meshbay-node", "mbnodestoptest-none") + .replace("meshbay-cli", name)) + copy = tmp_path / "stop-node-test.ps1" + copy.write_text(script, encoding="utf-8") + # The 32-bit PowerShell, as setup runs it ($SYSDIR is SysWOW64 in a 32-bit + # installer): from there Get-Process reads no path of a 64-bit process, and + # the first version of this stop matched nothing, live. + windir = os.environ.get("SystemRoot", r"C:\Windows") + pwsh = os.path.join(windir, "SysWOW64", "WindowsPowerShell", "v1.0", "powershell.exe") + if not os.path.exists(pwsh): + pwsh = shutil.which("powershell") + try: + r = subprocess.run([pwsh, "-NoProfile", "-ExecutionPolicy", "Bypass", "-File", + str(copy), "-InstallDir", str(install)], + capture_output=True, text=True, timeout=90) + assert r.returncode == 0, r.stdout + r.stderr + assert ours.wait(timeout=10) is not None + assert other.poll() is None, "a copy outside this install was ended" + finally: + for p in procs: + if p.poll() is None: + p.kill() + + +@pytest.mark.skipif(sys.platform != "win32", reason="runs the installer's PowerShell for real") def test_setup_stops_a_node_that_answers_through_its_control_api(tmp_path): """The graceful path: the script finds port and token where the node keeps them, POSTs /api/shutdown, and waits for the process to go -- here a stand-in |