1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
|
"""
A group named in the address: `#/name@owner[/path]`.
The handle under every group's name is also a link to it, and a path after it
names a folder to open or a file to download. `group-link.js` parses it,
builds it, finds the group among the account's own and the entry in the
group's index; the module is executed whole, as `test_search_source_merge.py`
does with `source-merge.js`, so these rules are the ones the page runs.
Also held here, at source level: the sign-in form no longer sends everyone
home, which is what made any link opened signed out land on the home page.
"""
import json
import re
import shutil
import subprocess
from pathlib import Path
import pytest
STATIC = Path(__file__).resolve().parents[1] / "src" / "meshbay_hub" / "static"
SRC = STATIC / "group-link.js"
IMPORT = re.compile(r"^\s*import\b", re.M)
EXPORT = re.compile(r"^export \{[^}]*\};?\s*$", re.M)
needs_node = pytest.mark.skipif(
shutil.which("node") is None or not SRC.exists(),
reason="node or the SPA sources are not available")
@pytest.fixture(scope="module")
def module_source():
text = SRC.read_text(encoding="utf-8")
assert not IMPORT.search(text), (
"group-link.js has gained an import; this test runs it standalone")
stripped, n = EXPORT.subn("", text)
assert n == 1
return stripped
def _run(tmp_path, module_source, expr):
script = tmp_path / "case.js"
script.write_text(f"{module_source}\nconsole.log(JSON.stringify({expr}));\n",
encoding="utf-8")
out = subprocess.run(["node", str(script)], capture_output=True, text=True,
encoding="utf-8", timeout=30)
assert out.returncode == 0, out.stderr
return json.loads(out.stdout)
GROUPS = [
{"id": "g1", "name": "demo", "owner_username": "someowner"},
{"id": "g2", "name": "demo", "owner_username": "otherowner"},
{"id": "g3", "name": "trips@home", "owner_username": "someowner"},
{"id": "g4", "name": "a/b c", "owner_username": "someowner"},
]
ENTRIES = [
{"path": "backup/city_2015/backup", "name": "IMG_0001.JPG"},
{"path": "backup/city_2015", "name": "notes.txt"},
{"path": "music", "name": "track 01.flac"},
]
@needs_node
@pytest.mark.parametrize("route, expected", [
("/demo@someowner", {"name": "demo", "owner": "someowner", "path": ""}),
("/demo@someowner/backup/city_2015/backup/IMG_0001.JPG",
{"name": "demo", "owner": "someowner",
"path": "backup/city_2015/backup/IMG_0001.JPG"}),
# The owner is after the last `@`: a group name may hold one, a username not.
("/trips@home@someowner", {"name": "trips@home", "owner": "someowner", "path": ""}),
# Each segment decoded on its own: an escaped `/` stays inside its segment.
("/a%2Fb%20c@someowner/music/track%2001.flac",
{"name": "a/b c", "owner": "someowner", "path": "music/track 01.flac"}),
("/demo@someowner/music/", {"name": "demo", "owner": "someowner", "path": "music"}),
# Every other route, and anything that is not a well-formed handle.
("/group/0f8fad5b-d9cb-469f-a165-70867728950e", None),
("/login", None), ("/", None), ("", None),
("/@someowner", None), ("/demo@", None),
("/demo@someowner/%E0%A4%A", None),
("/demo@someowner/music/../../etc", None),
])
def test_parse(tmp_path, module_source, route, expected):
assert _run(tmp_path, module_source, f"parseGroupLink({json.dumps(route)})") == expected
@needs_node
@pytest.mark.parametrize("group, path", [
(GROUPS[0], ""),
(GROUPS[0], "backup/city_2015/backup/IMG_0001.JPG"),
(GROUPS[2], ""),
(GROUPS[3], "music/track 01.flac"),
({"name": "Été à la mer", "owner_username": "someowner"}, "photos/plage #1.jpg"),
])
def test_built_routes_parse_back(tmp_path, module_source, group, path):
out = _run(tmp_path, module_source,
f"(() => {{ const r = groupLinkRoute({json.dumps(group)}, {json.dumps(path)});"
f" return [r, parseGroupLink(r)]; }})()")
route, parsed = out
assert parsed == {"name": group["name"], "owner": group["owner_username"], "path": path}
# Nothing that ends or splits a fragment is left bare.
assert not re.search(r"[#?\s%](?![0-9A-F]{2})", route)
@needs_node
def test_a_plain_handle_stays_readable(tmp_path, module_source):
route = _run(tmp_path, module_source,
f"groupLinkRoute({json.dumps(GROUPS[0])}, 'backup/city_2015/IMG_1.JPG')")
assert route == "/demo@someowner/backup/city_2015/IMG_1.JPG"
@needs_node
@pytest.mark.parametrize("link, expected", [
({"name": "demo", "owner": "someowner"}, "g1"),
({"name": "demo", "owner": "otherowner"}, "g2"),
# The hub keeps names unique on lower(name).
({"name": "DEMO", "owner": "someowner"}, "g1"),
({"name": "demo", "owner": "SomeOwner"}, "g1"),
# Not among the account's groups: nothing, and nothing asked of the hub.
({"name": "demo", "owner": "stranger1"}, None),
({"name": "secret", "owner": "someowner"}, None),
])
def test_find_among_own_groups(tmp_path, module_source, link, expected):
out = _run(tmp_path, module_source,
f"(findLinkedGroup({json.dumps(GROUPS)}, {json.dumps(link)}) || {{}}).id || null")
assert out == expected
@needs_node
@pytest.mark.parametrize("path, expected", [
("backup/city_2015/backup/IMG_0001.JPG",
{"kind": "file", "entry": ENTRIES[0]}),
("backup/city_2015/notes.txt", {"kind": "file", "entry": ENTRIES[1]}),
("backup/city_2015", {"kind": "dir", "dir": "backup/city_2015"}),
("backup", {"kind": "dir", "dir": "backup"}),
# An empty folder exists only in the node's own listing.
("backup/empty", {"kind": "dir", "dir": "backup/empty"}),
# A prefix of a folder name is not that folder.
("backup/city", None),
("backup/city_2015/backup/img_0001.jpg", None),
("", None),
])
def test_resolve_in_index(tmp_path, module_source, path, expected):
out = _run(tmp_path, module_source,
f"resolveLinkedPath({json.dumps(ENTRIES)}, ['backup/empty'], {json.dumps(path)})")
assert out == expected
def test_signing_in_keeps_the_page_the_address_names():
"""A group or file link opened signed out shows the sign-in form in its
place; signing in must leave the address alone, not send everyone home."""
source = (STATIC / "auth-page.js").read_text(encoding="utf-8")
body = source[source.index("export function LoginPage"):]
body = body[:body.index("\n}\n")]
assert "navigate('/')" not in body and 'navigate("/")' not in body
assert "if (loadPending()) navigate('/invite');" in body
def test_the_router_resolves_a_handle_and_shows_it():
source = (STATIC / "app.js").read_text(encoding="utf-8")
body = source[source.index("\nfunction App() {"):]
assert "parseGroupLink(route)" in body
assert "findLinkedGroup(groups, groupLink)" in body
# Rewritten with `replace`: showing the handle is not a history entry.
assert "window.location.replace('#' + shownGroupRoute)" in body
# The sidebar highlights the group whichever form opened it.
assert re.search(r"<\$\{Sidebar\}[\s\S]*?route=\$\{groupRoute\}", body)
|